Bug#925861: xbill: ftbfs with GCC-9

[Matthias Klose]

Package: src:xbill
Version: 2.1-8
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-9

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-9/g++-9, but succeeds to build with gcc-8/g++-8. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc9-20190321/xbill_2.1-8_unstable_gcc9.log
The last lines of the build log are at the end of this report.

To build with GCC 9, either set CC=gcc-9 CXX=g++-9 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-9/porting_to.html

GCC 9 also passes the linker option --as-needed by default; typical
build issues are passing libraries before object files to the linker,
or underlinking of convenience libraries built from the same source.

[...]
checking for c++... c++
checking whether the C++ compiler (c++  ) works... yes
checking whether the C++ compiler (c++  ) is a cross-compiler... no
checking whether we are using GNU C++... yes
checking whether c++ accepts -g... yes
checking for X... libraries , headers 
checking for dnet_ntoa in -ldnet... no
checking for dnet_ntoa in -ldnet_stub... no
checking for gethostbyname... yes
checking for connect... yes
checking for remove... yes
checking for shmat... yes
checking for IceConnectionNumber in -lICE... yes
checking for ANSI C header files... yes
checking for unistd.h... yes
checking for working const... yes
checking for XawInitializeWidgetSet in -lXaw3d... no
checking for XawInitializeWidgetSet in -lXaw... yes
updating cache ./config.cache
creating ./config.status
creating Makefile
creating config.h
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_build -a -O--parallel
dh_auto_build: Compatibility levels before 9 are deprecated (level 7 in use)
	make -j4
make[1]: Entering directory '/<<PKGBUILDDIR>>'
gcc -g -O2  -I. -c Bill.c -o Bill.o
gcc -g -O2  -I. -c Bucket.c -o Bucket.o
gcc -g -O2  -I. -c Cable.c -o Cable.o
gcc -g -O2  -I. -c Computer.c -o Computer.o
gcc -g -O2  -I. -c Game.c -o Game.o
Game.c: In function 'parse_args':
Game.c:258:7: warning: implicit declaration of function 'strncasecmp' [-Wimplicit-function-declaration]
  258 |   if (strncasecmp(argv[i], "-l", 2) == 0) {
      |       ^~~~~~~~~~~
Game.c:258:34: warning: 'strncasecmp' argument 3 type is 'int' where 'long unsigned int' is expected in a call to built-in function declared without prototype [-Wbuiltin-declaration-mismatch]
  258 |   if (strncasecmp(argv[i], "-l", 2) == 0) {
      |                                  ^
<built-in>: note: built-in 'strncasecmp' declared here
gcc -g -O2  -I. -c Horde.c -o Horde.o
gcc -g -O2  -I. -c Network.c -o Network.o
gcc -g -O2  -I. -c OS.c -o OS.o
gcc -g -O2  -I. -DSCOREFILE=\"/var/games/xbill.scores\" -c Scorelist.c -o Scorelist.o
gcc -g -O2  -I. -c Spark.c -o Spark.o
gcc -g -O2  -I. -c UI.c -o UI.o
gcc -g -O2  -I. -c util.c -o util.o
UI.c: In function 'UI_initialize':
UI.c:91:8: warning: implicit declaration of function 'strcasecmp' [-Wimplicit-function-declaration]
   91 |    if (strcasecmp(gui, map->name) == 0)
      |        ^~~~~~~~~~
gcc -g -O2  -I.  -c x11-athena.c -o x11-athena.o
gcc -g -O2  -I.  -DIMAGES=\"/usr/share/xbill\" -c x11.c -o x11.o
x11-athena.c: In function 'popup':
x11-athena.c:34:26: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   34 |  x11_athena_popup_dialog((int)client_data);
      |                          ^
x11-athena.c: In function 'new_menu_item':
x11-athena.c:42:47: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   42 |  XtAddCallback(menu_item, XtNcallback, popup, (void *) dialog);
      |                                               ^
gcc -g -O2  -lXpm -o xbill Bill.o Bucket.o Cable.o Computer.o Game.o Horde.o Network.o OS.o Scorelist.o Spark.o UI.o util.o  x11-athena.o x11.o -lXaw -lXmu -lXt -lX11  -lSM -lICE
/usr/bin/ld: x11.o: undefined reference to symbol 'XpmReadFileToPixmap'
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libXpm.so: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:63: xbill] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j4 returned exit code 2
make: *** [debian/rules:7: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2