Bug#925866: xteddy: ftbfs with GCC-9

[Matthias Klose]

Package: src:xteddy
Version: 2.2-3
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-9

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-9/g++-9, but succeeds to build with gcc-8/g++-8. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc9-20190321/xteddy_2.2-3_unstable_gcc9.log
The last lines of the build log are at the end of this report.

To build with GCC 9, either set CC=gcc-9 CXX=g++-9 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-9/porting_to.html

GCC 9 also passes the linker option --as-needed by default; typical
build issues are passing libraries before object files to the linker,
or underlinking of convenience libraries built from the same source.

[...]
make[2]: Leaving directory '/<<PKGBUILDDIR>>/html'
Making all in images
make[2]: Entering directory '/<<PKGBUILDDIR>>/images'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/<<PKGBUILDDIR>>/images'
make[2]: Entering directory '/<<PKGBUILDDIR>>'
gcc -DPIXMAP_PATH=\"/usr/share/xteddy\" -Wall -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -c -o xteddy.o xteddy.c
xteddy.c: In function 'main':
xteddy.c:203:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
  203 |     if ( (!strncmp(argv[argnum],"-F", 2)) || ( (!strncmp(argv[argnum],"-f", 2)) && (strcmp(argv[argnum],"-float")) ) )
      |     ^~
xteddy.c:205:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  205 |       if (strlen(teddy) == 0){ /* accept "-f <name>" as well as "-f<name>" */
      |       ^~
xteddy.c:156:24: warning: variable 'charcount' set but not used [-Wunused-but-set-variable]
  156 |   int                  charcount;
      |                        ^~~~~~~~~
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -lImlib2 -lX11 -lXext -Wl,-z,relro -Wl,-z,now -o xteddy xteddy.o  
/usr/bin/ld: xteddy.o: in function `main':
./xteddy.c:197: undefined reference to `XParseGeometry'
/usr/bin/ld: ./xteddy.c:234: undefined reference to `XOpenDisplay'
/usr/bin/ld: ./xteddy.c:245: undefined reference to `imlib_set_color_usage'
/usr/bin/ld: ./xteddy.c:247: undefined reference to `imlib_context_set_dither'
/usr/bin/ld: ./xteddy.c:249: undefined reference to `imlib_context_set_display'
/usr/bin/ld: ./xteddy.c:250: undefined reference to `imlib_context_set_visual'
/usr/bin/ld: ./xteddy.c:251: undefined reference to `imlib_context_set_colormap'
/usr/bin/ld: ./xteddy.c:257: undefined reference to `imlib_load_image_immediately'
/usr/bin/ld: ./xteddy.c:261: undefined reference to `imlib_context_set_image'
/usr/bin/ld: ./xteddy.c:262: undefined reference to `imlib_image_get_width'
/usr/bin/ld: ./xteddy.c:263: undefined reference to `imlib_image_get_height'
/usr/bin/ld: ./xteddy.c:276: undefined reference to `XCreateSimpleWindow'
/usr/bin/ld: ./xteddy.c:280: undefined reference to `XSelectInput'
/usr/bin/ld: ./xteddy.c:282: undefined reference to `imlib_context_set_drawable'
/usr/bin/ld: ./xteddy.c:283: undefined reference to `imlib_render_pixmaps_for_whole_image'
/usr/bin/ld: ./xteddy.c:284: undefined reference to `XSetWindowBackgroundPixmap'
/usr/bin/ld: ./xteddy.c:285: undefined reference to `XShapeCombineMask'
/usr/bin/ld: ./xteddy.c:286: undefined reference to `XFreePixmap'
/usr/bin/ld: ./xteddy.c:287: undefined reference to `XFreePixmap'
/usr/bin/ld: ./xteddy.c:288: undefined reference to `imlib_free_image_and_decache'
/usr/bin/ld: ./xteddy.c:302: undefined reference to `XCreateBitmapFromData'
/usr/bin/ld: ./xteddy.c:308: undefined reference to `XCreatePixmapCursor'
/usr/bin/ld: ./xteddy.c:309: undefined reference to `XFreePixmap'
/usr/bin/ld: ./xteddy.c:316: undefined reference to `XChangeWindowAttributes'
/usr/bin/ld: ./xteddy.c:324: undefined reference to `XStringListToTextProperty'
/usr/bin/ld: ./xteddy.c:340: undefined reference to `XSetWMProperties'
/usr/bin/ld: ./xteddy.c:349: undefined reference to `XSelectInput'
/usr/bin/ld: ./xteddy.c:352: undefined reference to `XMapWindow'
/usr/bin/ld: ./xteddy.c:357: undefined reference to `XNextEvent'
/usr/bin/ld: ./xteddy.c:395: undefined reference to `XCheckMaskEvent'
/usr/bin/ld: ./xteddy.c:396: undefined reference to `XQueryPointer'
/usr/bin/ld: ./xteddy.c:401: undefined reference to `XReconfigureWMWindow'
/usr/bin/ld: ./xteddy.c:413: undefined reference to `XLookupString'
/usr/bin/ld: ./xteddy.c:419: undefined reference to `XCloseDisplay'
/usr/bin/ld: ./xteddy.c:386: undefined reference to `XQueryPointer'
/usr/bin/ld: ./xteddy.c:390: undefined reference to `XReconfigureWMWindow'
/usr/bin/ld: ./xteddy.c:379: undefined reference to `XRaiseWindow'
/usr/bin/ld: ./xteddy.c:381: undefined reference to `XQueryPointer'
/usr/bin/ld: ./xteddy.c:409: undefined reference to `XRaiseWindow'
/usr/bin/ld: ./xteddy.c:375: undefined reference to `XUngrabKeyboard'
/usr/bin/ld: ./xteddy.c:370: undefined reference to `XGrabKeyboard'
/usr/bin/ld: ./xteddy.c:312: undefined reference to `XCreateFontCursor'
/usr/bin/ld: ./xteddy.c:236: undefined reference to `XDisplayName'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:447: xteddy] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:562: all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: make -j4 returned exit code 2
make: *** [debian/rules:8: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2