Bug#957333: heroes: ftbfs with GCC-10

[Matthias Klose]

Package: src:heroes
Version: 0.21-17
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/heroes_0.21-17_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
print "\t{ \""toupper(substr($1,index($1,"_")+1))"\",", $1,"}," } \
END { print "\t{ 0, 0 }};\n" }' > media/sdl/keysdef.c ; \
fi
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o heroeslvl.o heroeslvl.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/de_body.o lvl/de_body.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/de_head.o lvl/de_head.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/en_body.o lvl/en_body.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/en_head.o lvl/en_head.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/free.o lvl/free.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/in_body.o lvl/in_body.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/load.o lvl/load.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/privacc.o lvl/privacc.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o lvl/save.o lvl/save.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/keyb.o media/keyb.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/video.o media/video.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/strack.o media/strack.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/sfx.o media/sfx.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/sdl/libhsdlj_a-joystick.o `test -f 'media/sdl/joystick.c' || echo './'`media/sdl/joystick.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/sdl_mixer/libhsdls_a-strack.o `test -f 'media/sdl_mixer/strack.c' || echo './'`media/sdl_mixer/strack.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/sdl_mixer/libhsdls_a-sfx.o `test -f 'media/sdl_mixer/sfx.c' || echo './'`media/sdl_mixer/sfx.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o media/sdl/libhsdlvkm_a-keysdef.o `test -f 'media/sdl/keysdef.c' || echo './'`media/sdl/keysdef.c
gcc -DHAVE_CONFIG_H -I. -I.. -I../lib -I../lib -I../intl -I./lvl -I./media -I./sys -I.. -I.  -Wdate-time -D_FORTIFY_SOURCE=2  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer -c -o sys/std/libhsdlm_a-main.o `test -f 'sys/std/main.c' || echo './'`sys/std/main.c
rm -f lvl/libhlvl.a
ar cru lvl/libhlvl.a lvl/de_body.o lvl/de_head.o lvl/en_body.o lvl/en_head.o lvl/free.o lvl/in_body.o lvl/load.o lvl/privacc.o lvl/save.o 
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib lvl/libhlvl.a
rm -f media/libhsdlj.a
ar cru media/libhsdlj.a media/sdl/libhsdlj_a-joystick.o 
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib media/libhsdlj.a
rm -f media/libhsdls.a
ar cru media/libhsdls.a media/sdl_mixer/libhsdls_a-strack.o media/sdl_mixer/libhsdls_a-sfx.o 
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer  -Wl,-z,relro -Wl,-z,now -o heroeslvl heroeslvl.o lvl/libhlvl.a ../lib/libheroes.a  -lm 
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib media/libhsdls.a
rm -f sys/libhsdlm.a
ar cru sys/libhsdlm.a sys/std/libhsdlm_a-main.o 
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib sys/libhsdlm.a
rm -f media/libhmcommon.a
ar cru media/libhmcommon.a media/keyb.o media/video.o media/strack.o media/sfx.o 
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib media/libhmcommon.a
rm -f media/libhsdlvkm.a
ar cru media/libhsdlvkm.a media/sdl/libhsdlvkm_a-keyb.o media/sdl/libhsdlvkm_a-keyvalues.o media/sdl/libhsdlvkm_a-video.o media/sdl/libhsdlvkm_a-keysdef.o 
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib media/libhsdlvkm.a
gcc  -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -g -O3 -ffast-math -fstrict-aliasing -fomit-frame-pointer  -Wl,-z,relro -Wl,-z,now -o heroes argv.o bonus.o camera.o const.o debughash.o debugmsg.o endscroll.o errors.o explosions.o extras.o fader.o fontdata.o gameid.o hedlite.o helptext.o hendian.o heroes.o intro.o items.o levellst.o locales.o menus.o misc.o musicfiles.o parafmt.o pcx.o pendulum.o people.o persona.o pixelize.o prefs.o readmake.o relocate.o render.o renderdata.o rsc_files.o rsc_files_hash.o savegame.o scores.o scrtools.o sprglauto.o sprglenz.o sprite.o spropaque.o sprprog.o sprprogwav.o sprrle.o sprshade.o sprtext.o sprunish.o sprzcol.o timer.o userconf.o userdir.o vars.o visuals.o lvl/libhlvl.a media/libhmcommon.a ../lib/libheroes.a  media/libhsdlj.a media/libhsdls.a media/libhsdlvkm.a  sys/libhsdlm.a -lSDL_mixer -L/usr/lib/x86_64-linux-gnu -lSDL  sys/libhsdlm.a -lm 
/usr/bin/ld: persona.o:./src/persona.h:32: multiple definition of `keep_suid'; heroes.o:./src/persona.h:32: first defined here
/usr/bin/ld: persona.o:./src/persona.h:31: multiple definition of `keep_sgid'; heroes.o:./src/persona.h:31: first defined here
/usr/bin/ld: savegame.o:./src/persona.h:32: multiple definition of `keep_suid'; heroes.o:./src/persona.h:32: first defined here
/usr/bin/ld: savegame.o:./src/persona.h:31: multiple definition of `keep_sgid'; heroes.o:./src/persona.h:31: first defined here
/usr/bin/ld: scores.o:./src/persona.h:32: multiple definition of `keep_suid'; heroes.o:./src/persona.h:32: first defined here
/usr/bin/ld: scores.o:./src/persona.h:31: multiple definition of `keep_sgid'; heroes.o:./src/persona.h:31: first defined here
/usr/bin/ld: userconf.o:./src/persona.h:31: multiple definition of `keep_sgid'; heroes.o:./src/persona.h:31: first defined here
/usr/bin/ld: userconf.o:./src/persona.h:32: multiple definition of `keep_suid'; heroes.o:./src/persona.h:32: first defined here
collect2: error: ld returned 1 exit status
make[5]: *** [Makefile:1239: heroes] Error 1
make[5]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[4]: *** [Makefile:919: all] Error 2
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[3]: *** [Makefile:527: all-recursive] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>'
make[2]: *** [Makefile:465: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make[1]: *** [debian/rules:27: override_dh_auto_build-arch] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2