Bug#957394: jumpnbump: ftbfs with GCC-10

[Matthias Klose]

Package: src:jumpnbump
Version: 1.61-2
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/jumpnbump_1.61-2_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
jnbunpack.c: In function ‘main’:
jnbunpack.c:65:5: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   65 |     read(fd, &num_entries, 4);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~
jnbunpack.c:70:5: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   70 |     read(fd, datafile, num_entries * sizeof(DirEntry));
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jnbunpack.c:100:2: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  100 |  read(fd, buf, datafile[i].size);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
jnbunpack.c:101:2: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  101 |  write(outfd, buf, datafile[i].size);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT `sdl2-config --cflags` -I. -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT -I. -I.. -o ../jnbpack jnbpack.o -Wl,-z,relro -Wl,-z,now 
cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT `sdl2-config --cflags` -I. -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT -I. -I.. -o ../jnbunpack jnbunpack.o -Wl,-z,relro -Wl,-z,now 
cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT `sdl2-config --cflags` -I. -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT `sdl2-config --cflags` -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2  -c -o sound.o sound.c
make[3]: Leaving directory '/<<PKGBUILDDIR>>/modify'
make -C data
make[3]: Entering directory '/<<PKGBUILDDIR>>/data'
exec ../gobpack font
font.gob build
exec ../gobpack numbers
numbers.gob build
exec ../gobpack objects
objects.gob build
exec ../gobpack rabbit
rabbit.gob build
exec ../jnbpack -o jumpbump.dat bump.mod calib.dat death.smp fly.smp jump.mod jump.smp levelmap.txt level.pcx mask.pcx menu.pcx menumask.pcx font.gob numbers.gob objects.gob rabbit.gob scores.mod splash.smp spring.smp
18 files to pack
Opened jumpbump.dat
adding bump.mod  OK
adding calib.dat  OK
adding death.smp  OK
adding fly.smp  OK
adding jump.mod  OK
adding jump.smp  OK
adding levelmap.txt  OK
adding level.pcx  OK
adding mask.pcx  OK
adding menu.pcx  OK
adding menumask.pcx  OK
adding font.gob  OK
adding numbers.gob  OK
adding objects.gob  OK
adding rabbit.gob  OK
adding scores.mod  OK
adding splash.smp  OK
adding spring.smp  OK
make[3]: Leaving directory '/<<PKGBUILDDIR>>/data'
cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT `sdl2-config --cflags` -I. -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT `sdl2-config --cflags` -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2  -c -o input.o input.c
ar cru ../sdl.a gfx.o interrpt.o sound.o input.o
ar: `u' modifier ignored since `D' is the default (see `U')
ranlib ../sdl.a
make[3]: Leaving directory '/<<PKGBUILDDIR>>/sdl'
cc -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Dstricmp=strcasecmp -Dstrnicmp=strncasecmp -DNDEBUG -DUSE_SDL -DUSE_NET -DZLIB_SUPPORT -DBZLIB_SUPPORT `sdl2-config --cflags` -I. -o jumpnbump main.o menu.o filter.o network.o -Wl,-z,relro -Wl,-z,now sdl.a `sdl2-config --libs` -lSDL2_mixer -lSDL2_net -lbz2 -lz -lm
/usr/bin/ld: menu.o:./globals.h:270: multiple definition of `endscore_reached'; main.o:./globals.h:270: first defined here
/usr/bin/ld: network.o:./globals.h:270: multiple definition of `endscore_reached'; main.o:./globals.h:270: first defined here
/usr/bin/ld: network.o:./network.h:77: multiple definition of `net_info'; main.o:./network.h:77: first defined here
/usr/bin/ld: sdl.a(gfx.o):./sdl/../globals.h:270: multiple definition of `endscore_reached'; main.o:./globals.h:270: first defined here
/usr/bin/ld: sdl.a(interrpt.o):./sdl/../globals.h:270: multiple definition of `endscore_reached'; main.o:./globals.h:270: first defined here
/usr/bin/ld: sdl.a(sound.o):./sdl/../globals.h:270: multiple definition of `endscore_reached'; main.o:./globals.h:270: first defined here
/usr/bin/ld: sdl.a(input.o):./sdl/../globals.h:270: multiple definition of `endscore_reached'; main.o:./globals.h:270: first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:41: jumpnbump] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 "INSTALL=install --strip-program=true" PREFIX=/usr BINDIR=/usr/games GAMEDATADIR=/usr/share/games returned exit code 2
make[1]: *** [debian/rules:9: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:6: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2