Bug#997154: freesweep: FTBFS: error.c:46:38: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: freesweep
Version: 1.0.1-2
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> gcc -Wall -DVERSION=\"1.0.1\" -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -c fgui.c
> In file included from drawing.c:11:
> sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
>    66 | #define USE_GROUP_BEST_FILE
>       | 
> In file included from sweep.h:8,
>                  from drawing.c:11:
> config.h:26: note: this is the location of the previous definition
>    26 | #define USE_GROUP_BEST_FILE 1
>       | 
> In file included from clear.c:13:
> sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
>    66 | #define USE_GROUP_BEST_FILE
>       | 
> In file included from error.c:11:
> sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
>    66 | #define USE_GROUP_BEST_FILE
>       | 
> In file included from sweep.h:8,
>                  from error.c:11:
> config.h:26: note: this is the location of the previous definition
>    26 | #define USE_GROUP_BEST_FILE 1
>       | 
> In file included from sweep.h:8,
>                  from clear.c:13:
> config.h:26: note: this is the location of the previous definition
>    26 | #define USE_GROUP_BEST_FILE 1
>       | 
> error.c: In function ‘SweepError’:
> error.c:46:38: error: format not a string literal and no format arguments [-Werror=format-security]
>    46 |                 mvwprintw(ErrWin,0,0,NewErrMsg);
>       |                                      ^~~~~~~~~
> error.c: In function ‘SweepMessage’:
> error.c:129:30: error: format not a string literal and no format arguments [-Werror=format-security]
>   129 |         mvwprintw(ErrWin,0,0,NewErrMsg);
>       |                              ^~~~~~~~~
> In file included from fgui.c:11:
> sweep.h:66: warning: "USE_GROUP_BEST_FILE" redefined
>    66 | #define USE_GROUP_BEST_FILE
>       | 
> In file included from sweep.h:8,
>                  from fgui.c:11:
> config.h:26: note: this is the location of the previous definition
>    26 | #define USE_GROUP_BEST_FILE 1
>       | 
> drawing.c: In function ‘Help’:
> drawing.c:596:25: error: format not a string literal and no format arguments [-Werror=format-security]
>   596 |                         mvwprintw(HelpWin,CurrentY++,8,Messages[CurrentLine++]);
>       |                         ^~~~~~~~~
> drawing.c:636:25: error: format not a string literal and no format arguments [-Werror=format-security]
>   636 |                         mvwprintw(HelpWin,CurrentY++,8,Messages[CurrentLine++]);
>       |                         ^~~~~~~~~
> fgui.c: In function ‘Display’:
> fgui.c:308:9: error: format not a string literal and no format arguments [-Werror=format-security]
>   308 |         mvwprintw(fgui, 0, 3, fb[0].path);
>       |         ^~~~~~~~~
> fgui.c:313:17: warning: this ‘while’ clause does not guard... [-Wmisleading-indentation]
>   313 |                 while(*p != '/') p--; p++; /* there will always be a / in it */
>       |                 ^~~~~
> fgui.c:313:39: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘while’
>   313 |                 while(*p != '/') p--; p++; /* there will always be a / in it */
>       |                                       ^
> fgui.c:314:17: error: format not a string literal and no format arguments [-Werror=format-security]
>   314 |                 mvwprintw(fgui, i+1, 1, p);
>       |                 ^~~~~~~~~
> fgui.c: In function ‘CreateFileBuf’:
> fgui.c:41:9: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>    41 |         chdir(dir);
>       |         ^~~~~~~~~~
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:41: error.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/freesweep_1.0.1-2_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.