Bug#997168: scottfree: FTBFS: ScottCurses.c:402:32: error: format not a string literal and no format arguments [-Werror=format-security]

[Lucas Nussbaum]

Source: scottfree
Version: 1.14-10.1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> gcc -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2  -c -o ScottCurses.o ScottCurses.c
> ScottCurses.c: In function ‘OutBuf’:
> ScottCurses.c:402:32: error: format not a string literal and no format arguments [-Werror=format-security]
>   402 |                 wprintw(Bottom,word);
>       |                                ^~~~
> ScottCurses.c: In function ‘LoadDatabase’:
> ScottCurses.c:303:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   303 |                 fscanf(f,"%hd %hd %hd %hd %hd %hd",
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   304 |                         &rp->Exits[0],&rp->Exits[1],&rp->Exits[2],
>       |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   305 |                         &rp->Exits[3],&rp->Exits[4],&rp->Exits[5]);
>       |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ScottCurses.c:335:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   335 |                 fscanf(f,"%hd",&lo);
>       |                 ^~~~~~~~~~~~~~~~~~~
> ScottCurses.c:348:9: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   348 |         fscanf(f,"%d",&ct);
>       |         ^~~~~~~~~~~~~~~~~~
> ScottCurses.c:352:9: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   352 |         fscanf(f,"%d",&ct);
>       |         ^~~~~~~~~~~~~~~~~~
> ScottCurses.c: In function ‘LoadGame’:
> ScottCurses.c:695:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   695 |                 fscanf(f,"%d %d\n",&Counters[ct],&RoomSaved[ct]);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ScottCurses.c:697:9: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   697 |         fscanf(f,"%ld %hd %hd %d %d %hd\n",
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   698 |                 &BitFlags,&DarkFlag,&MyLoc,&CurrentCounter,&SavedRoom,
>       |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>   699 |                 &GameHeader.LightTime);
>       |                 ~~~~~~~~~~~~~~~~~~~~~~
> ScottCurses.c:705:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
>   705 |                 fscanf(f,"%hd\n",&lo);
>       |                 ^~~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[1]: *** [<builtin>: ScottCurses.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2021/10/23/scottfree_1.14-10.1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please marking it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.