Bug#1089492: unknown-horizons installs the very generic filename /usr/share/locale/stats.json

[Tobias Frost]

On Sat, Dec 07, 2024 at 03:20:55PM -0800, Josh Triplett wrote:
> Package: unknown-horizons
> Severity: normal
> X-Debbugs-Cc: josh at joshtriplett.org
> 
> unknown-horizons installs the file /usr/share/locale/stats.json, which
> seems like a very generic filename and not one specific to
> unknown-horizons.
> 
> Is this actually localization data (e.g. translations), or something
> else?
> 
> If this is localization data, and unknown-horizons can handle it being
> missing, then please consider renaming it to something like
> `/usr/share/locale/unknown-horizons/stats.json`.
> 
> If this is *not* localization data, please move it to something like
> `/usr/share/unknown-horizons/stats.json`.

There is a codepath when the file is not found, so unknown horizon
should just work fine without the file. It just won't tell in the UI
about the translated percentage.

Code:
https://salsa.debian.org/games-team/unknown-horizons/-/blob/master/horizons/gui/modules/settings.py?ref_type=heads#L300
https://salsa.debian.org/games-team/unknown-horizons/-/blob/master/horizons/i18n/__init__.py?ref_type=heads#L168


> 
> -- System Information:
> Debian Release: trixie/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> Foreign Architectures: arm64
> 
> Kernel: Linux 6.11.10-amd64 (SMP w/12 CPU threads; PREEMPT)
> Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages unknown-horizons depends on:
> pn  fonts-unifont  <none>
> ii  python3        3.12.7-1
> pn  python3-enet   <none>
> pn  python3-fife   <none>
> pn  python3-yaml   <none>
> 
> unknown-horizons recommends no packages.
> 
> unknown-horizons suggests no packages.
>