Bug#1089492: unknown-horizons installs the very generic filename /usr/share/locale/stats.json

[Josh Triplett]

On Sun, 8 Dec 2024 12:36:56 +0100 Tobias Frost <tobi at debian.org> wrote:
> On Sat, Dec 07, 2024 at 03:20:55PM -0800, Josh Triplett wrote:
> > Package: unknown-horizons
> > Severity: normal
> > X-Debbugs-Cc: josh at joshtriplett.org
> > 
> > unknown-horizons installs the file /usr/share/locale/stats.json, which
> > seems like a very generic filename and not one specific to
> > unknown-horizons.
> > 
> > Is this actually localization data (e.g. translations), or something
> > else?
> > 
> > If this is localization data, and unknown-horizons can handle it being
> > missing, then please consider renaming it to something like
> > `/usr/share/locale/unknown-horizons/stats.json`.
> > 
> > If this is *not* localization data, please move it to something like
> > `/usr/share/unknown-horizons/stats.json`.
> 
> There is a codepath when the file is not found, so unknown horizon
> should just work fine without the file. It just won't tell in the UI
> about the translated percentage.
> 
> Code:
> https://salsa.debian.org/games-team/unknown-horizons/-/blob/master/horizons/gui/modules/settings.py?ref_type=heads#L300
> https://salsa.debian.org/games-team/unknown-horizons/-/blob/master/horizons/i18n/__init__.py?ref_type=heads#L168

The translation percentage is useful information; if possible, please
consider moving this file to something like
`/usr/share/locale/unknown-horizons/stats.json`. However, if that's not
feasible to do, then it sounds like removing it wouldn't do any harm.