Bug#1097861: scottfree: ftbfs with GCC-15

[Matthias Klose]

Package: src:scottfree
Version: 1.14-12
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/scottfree_1.14-12_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
dpkg-buildpackage: info: host architecture amd64
 debian/rules clean
dh clean
   dh_auto_clean
   dh_clean
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_configure
   dh_auto_build
	make -j8 "INSTALL=install --strip-program=true"
make[1]: Entering directory '/build/reproducible-path/scottfree-1.14'
gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/scottfree-1.14=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2  -c -o ScottCurses.o ScottCurses.c
ScottCurses.c: In function ‘GetInput’:
ScottCurses.c:600:6: warning: old-style function definition [-Wold-style-definition]
  600 | void GetInput(vb,no)
      |      ^~~~~~~~
ScottCurses.c: In function ‘main’:
ScottCurses.c:1358:23: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
 1358 |         signal(SIGINT,Aborted);         /* For BSD curses */
      |                       ^~~~~~~
      |                       |
      |                       void (*)(void)
In file included from ScottCurses.c:22:
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
ScottCurses.c:114:6: note: ‘Aborted’ declared here
  114 | void Aborted()
      |      ^~~~~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
ScottCurses.c: In function ‘LoadDatabase’:
ScottCurses.c:303:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  303 |                 fscanf(f,"%hd %hd %hd %hd %hd %hd",
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  304 |                         &rp->Exits[0],&rp->Exits[1],&rp->Exits[2],
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  305 |                         &rp->Exits[3],&rp->Exits[4],&rp->Exits[5]);
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ScottCurses.c:335:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  335 |                 fscanf(f,"%hd",&lo);
      |                 ^~~~~~~~~~~~~~~~~~~
ScottCurses.c:348:9: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  348 |         fscanf(f,"%d",&ct);
      |         ^~~~~~~~~~~~~~~~~~
ScottCurses.c:352:9: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  352 |         fscanf(f,"%d",&ct);
      |         ^~~~~~~~~~~~~~~~~~
ScottCurses.c: In function ‘LoadGame’:
ScottCurses.c:695:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  695 |                 fscanf(f,"%d %d\n",&Counters[ct],&RoomSaved[ct]);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ScottCurses.c:697:9: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  697 |         fscanf(f,"%ld %hd %hd %d %d %hd\n",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  698 |                 &BitFlags,&DarkFlag,&MyLoc,&CurrentCounter,&SavedRoom,
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  699 |                 &GameHeader.LightTime);
      |                 ~~~~~~~~~~~~~~~~~~~~~~
ScottCurses.c:705:17: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  705 |                 fscanf(f,"%hd\n",&lo);
      |                 ^~~~~~~~~~~~~~~~~~~~~
make[1]: *** [<builtin>: ScottCurses.o] Error 1
make[1]: Leaving directory '/build/reproducible-path/scottfree-1.14'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:6: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2