Bug#1097896: slashem: ftbfs with GCC-15

[Matthias Klose]

Package: src:slashem
Version: 0.0.7E7F3-12
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/slashem_0.0.7E7F3-12_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      | ^~~~~~~
ball.c: In function ‘drag_ball’:
ball.c:366:1: warning: old-style function definition [-Wold-style-definition]
  366 | drag_ball(x, y, bc_control, ballx, bally, chainx, chainy, cause_delay,
      | ^~~~~~~~~
ball.c: In function ‘drop_ball’:
ball.c:649:1: warning: old-style function definition [-Wold-style-definition]
  649 | drop_ball(x, y)
      | ^~~~~~~~~
cc -DDEBIAN_TTY -g -O2 -fomit-frame-pointer -fstack-protector -fcommon --param=ssp-buffer-size=4 -I../include -I/usr/X11R6/include -Wno-error=incompatible-pointer-types -Wdate-time -D_FORTIFY_SOURCE=2  -c -o bones.o bones.c
bones.c: In function ‘no_bones_level’:
bones.c:19:1: warning: old-style function definition [-Wold-style-definition]
   19 | no_bones_level(lev)
      | ^~~~~~~~~~~~~~
bones.c: In function ‘goodfruit’:
bones.c:44:1: warning: old-style function definition [-Wold-style-definition]
   44 | goodfruit(id)
      | ^~~~~~~~~
bones.c: In function ‘resetobjs’:
bones.c:58:1: warning: old-style function definition [-Wold-style-definition]
   58 | resetobjs(ochain,restore)
      | ^~~~~~~~~
bones.c: In function ‘drop_upon_death’:
bones.c:135:1: warning: old-style function definition [-Wold-style-definition]
  135 | drop_upon_death(mtmp, cont)
      | ^~~~~~~~~~~~~~~
bones.c: In function ‘savebones’:
bones.c:214:1: warning: old-style function definition [-Wold-style-definition]
  214 | savebones(corpse)
      | ^~~~~~~~~
cc -DDEBIAN_TTY -g -O2 -fomit-frame-pointer -fstack-protector -fcommon --param=ssp-buffer-size=4 -I../include -I/usr/X11R6/include -Wno-error=incompatible-pointer-types -Wdate-time -D_FORTIFY_SOURCE=2  -c -o botl.o botl.c
botl.c: In function ‘xlev_to_rank’:
botl.c:84:1: warning: old-style function definition [-Wold-style-definition]
   84 | xlev_to_rank(xlev)
      | ^~~~~~~~~~~~
botl.c: In function ‘rank_of’:
botl.c:101:1: warning: old-style function definition [-Wold-style-definition]
  101 | rank_of(lev, monnum, female)
      | ^~~~~~~
botl.c: In function ‘title_to_mon’:
botl.c:137:1: warning: old-style function definition [-Wold-style-definition]
  137 | title_to_mon(str, rank_indx, title_length)
      | ^~~~~~~~~~~~
botl.c: In function ‘describe_level’:
botl.c:279:1: warning: old-style function definition [-Wold-style-definition]
  279 | describe_level(buf, verbose)
      | ^~~~~~~~~~~~~~
botl.c: In function ‘shorten_bot2’:
botl.c:482:1: warning: old-style function definition [-Wold-style-definition]
  482 | shorten_bot2(str, len)
      | ^~~~~~~~~~~~
botl.c: In function ‘bot_raw’:
botl.c:501:13: warning: old-style function definition [-Wold-style-definition]
  501 | static void bot_raw(reconfig)
      |             ^~~~~~~
botl.c:571:6: error: too many arguments to function ‘raw_handler’; expected 0, have 3
  571 |     (*raw_handler)(reconfig, rv - botl_raw_values, botl_raw_values);
      |     ~^~~~~~~~~~~~~ ~~~~~~~~
botl.c: In function ‘bot_set_handler’:
botl.c:582:1: warning: old-style function definition [-Wold-style-definition]
  582 | bot_set_handler(handler)
      | ^~~~~~~~~~~~~~~
make[3]: *** [<builtin>: botl.o] Error 1
make[3]: Leaving directory '/build/reproducible-path/slashem-0.0.7E7F3/src'
make[2]: *** [Makefile:150: slashem] Error 2
make[2]: Leaving directory '/build/reproducible-path/slashem-0.0.7E7F3'
make[1]: *** [debian/rules:26: override_dh_auto_build] Error 2
make[1]: Leaving directory '/build/reproducible-path/slashem-0.0.7E7F3'
make: *** [debian/rules:4: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2