Bug#1136467: alien-arena uses pidof but does not depend on procps

[Gioele Barabucci]

Source: alien-arena
Version: 7.71.7+dfsg-1
Usertags: pidof-without-procps

Dear maintainer(s) of alien-arena,

it appears that alien-arena uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of alien-arena
  that use `pidof` at runtime;
* via the `Build-Depends:` field of alien-arena, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of alien-arena, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that alien-arena uses `pidof` due to the following
code snippets:

```
path: alien-arena_7.71.7+dfsg-1/Tools/LinuxScripts/check-master
# check server is running
echo "Checking for master server..."
if `pidof $bin >/dev/null 2>&1`
then
echo "Master server is currently running."
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci