Bug#1136521: libretro-bsnes-mercury uses pidof but does not depend on procps

[Gioele Barabucci]

Source: libretro-bsnes-mercury
Version: 094+git20220807-8
Usertags: pidof-without-procps

Dear maintainer(s) of libretro-bsnes-mercury,

it appears that libretro-bsnes-mercury uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of libretro-bsnes-mercury
  that use `pidof` at runtime;
* via the `Build-Depends:` field of libretro-bsnes-mercury, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of libretro-bsnes-mercury, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that libretro-bsnes-mercury uses `pidof` due to the following
code snippets:

```
path: libretro-bsnes-mercury_094+git20220807-8/nall/compositor.hpp
  pclose(fp);
  fp = popen("pidof xfwm4", "r");
  if(fp && fgets(buffer, sizeof buffer, fp)) result = Compositor::Xfwm4;
  pclose(fp);


path: libretro-bsnes-mercury_094+git20220807-8/nall/compositor.hpp
  char buffer[512];
  fp = popen("pidof metacity", "r");
  if(fp && fgets(buffer, sizeof buffer, fp)) result = Compositor::Metacity;
  pclose(fp);
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci