qtea_0.1.1-1_amd64.changes REJECTED

[Andrew McMillan]

Hi,

Packaging quality issues
========================

1. Wrong VCS URLs (copied from another package) — debian/control:7-8

Vcs-Browser: https://salsa.debian.org/games-team/nestopia
Vcs-Git: https://salsa.debian.org/games-team/nestopia.git

These point to the nestopia repository, not qtea. They were clearly copied from a different Debian Games Team package. The actual upstream is gitlab.com/jgemu/qtea (see debian/upstream/metadata:7-8), so these should be https://salsa.debian.org/games-team/qtea(.git).


2. Missing/incorrect license entry for src/font/6x8.h — debian/copyright

The file header states src/font/6x8.h:1: "Public Domain 6x8 console font". There is no Files: src/font/6x8.h section in debian/copyright, so it is silently captured by Files: * (lines 5-7) and mislabeled as BSD-3-Clause. It should have its own public-domain entry. Same applies to the CRC table — crc32.cpp has its own section (debian/copyright:21-25), which is correct, but the font is an oversight.


3. Minor: stale README attribution for shaders/sharp-bilinear.fs

README:44-45 credits it to "nyanpasu64 and wareya (MIT)", but the file header (shaders/sharp-bilinear.fs) and debian/copyright:9-11 both correctly credit Rupert Carmichael (2020-2022, MIT). The copyright file matches the actual header, so this is only an upstream README inconsistency — not a Debian defect, but worth noting since the README is the canonical license statement in the tree.

4. Minimal debian/rules

debian/rules:6-8 empties both dh_auto_configure and dh_auto_build and relies on --with single-binary. This is defensible for a source-shipping qtea-src package (nothing is compiled), and debian/qtea-src.install handles installation. Not a bug, but there's no override_dh_auto_install or dh_clean cleanup, and no Rules-Requires-Root field in debian/control — minor policy hygiene items.

5. Missing Author Credits

See full review details for a list of authors who are not credited in debian/copyright


Thanks!

Further information may be found at:
   https://dfsg-new-queue.debian.org/reviews/qtea

Regards, Andrew McMillan
Member of the DFSG, Licensing & New Packages Team



===

Please feel free to respond to this email if you don't understand why
your files were rejected, or if you upload new files which address our
concerns.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-games-devel/attachments/20260926/a0070c80/attachment.sig>