[Pkg-giraffe-discuss] zarafa-7.2.1 RC1 released

[Jelle van der Waa]

Hi,

Just a quick reply.

> But wait, I remember a patch from Jelle about dropping the JSON.php
> complete from the source inside the PHP files...

Yes I can rebase it and send it to you, if you still want it :)

> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/LICENSE.txt
> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/client/tinymce/jquery.tinymce.min.js
> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/client/tinymce/license.txt
> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/client/tinymce/plugins/media/moxieplayer.swf
> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/plugins/titlecounter/config.php
> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/plugins/titlecounter/js/titlecounter.js
> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/plugins/titlecounter/manifest.xml
> > -rw-r--r--  root/root   /usr/share/zarafa-webapp/plugins/titlecounter/php/plugin.titlecounter.php

Hmm, the titlecounter plugin is a valid plugin and should be fully AGPLv3. It modifies your tab title to show
the amount of unread emails.

> Yes, the PHP logging isn't clear to me, the htaccess file is using a
> relative path for the output file. Better using here a absolute path to
> /var/log/zarafa/ for example.
> 
> And some small more documentation inside .htaccess

About error reporting, we explicitly disable it for some unknown reason in config.php see this line:

"error_reporting(0);"

I'd say that's wrong and we should at least log errors to the Apache log. I will be investigating this, but I don't think the change will end up in 2.1.0

The last line of the htcacess requires some investigation I am not sure where or what should be logged there.
The option to enable short tags should be unnecessary, because we converted everything to non short open tags. 

Thanks for the hard work!

Jelle