[Pkg-giraffe-discuss] z-push: some signed tags missing on the repository

[Roel van Meer]

Carsten Schoenert writes:

> I started to have a look at your current state of the z-push git tree.

Let me start by saying thanks for the detailed feedback!
I've updated the debian/sid branch, which should address your current  
remarks.

> You probably have forgotten (or not pushed) to add some tags while
> importing some of the new upstream versions.

Forgotten, indeed. As you suspected gbp is relatively new for me.
I've added the signed tags and updated the existing one.

> For debian/patches, it seems you have chosen to work with quilt instead
> of using more flexible usage of git patches by using git-buildpackage, I
> or we wouldn't use quilt patch workflow.

For debian/sid I'm using the gbp patch-queue now. It is indeed much easier  
than quilt.

> Lintian is currently complaining about laking some description for two
> patches you've added.

I've added the comments from the commit messages to the patches. I hope  
that's enough.

Aside: how do you run lintian to get this error? I've tried to make the  
package lintian-clean, and my own lintian (2.5.52) only says:

  rolek at sid:~/git$ lintian z-push*changes
  W: z-push source: out-of-date-standards-version 3.9.8 (current is 4.0.0)
  N: 3 tags overridden (1 error, 2 warnings)

It would be nice if I could see those errors as well.

> Based on the also missed tags you seems not very familiar with the
> workflow git-buidlpackage is providing. You need any suggestions or help?

You've already given me lots of useful information here. I don't have any  
specific questions at the moment.

> The postrm and postinst script of z-push-common currently using some
> unfortunate usage of a variable 'service" that lintian is showing as
> error, this needs to be changed as the ftpmaster will probably will
> complaining also about that.
> I would simply drop $service and use only $1 here.

Done.

> There are some other things I wouldn't do in that way they are but that
> isn't something we need to sort out now. Anyway I think we start first
> with a upload to experimental, as the package needs go through NEW we
> have to wait on the ftpmasters at all.

It's all fine by me.

One thing I don't really like myself is the way autodiscover/INSTALL is  
renamed in the rules file, but I didn't know a better way to install two  
docs with the same name.

Thanks a lot,

Roel