[Pkg-giraffe-discuss] kopano-webapp-plugin-files: various license information

[Jelle van der Waa]

Hi, 

> >> Let's move over to the nice parts while doing packaging stuff,
> >> collecting all the information for the copyright file. :-)
> >>
> >> The Kopano stuff is clear, but within the php/ folder I still try to
> >> collect all together. The version of sabre-dav Debian is shipping in
> >> unstable/testing right now doesn't match the folder structure in the
> >> source, I guess the version in Debian is newer?
> >> What version of sabre-dav is Kopano using and would it be possible to
> >> add such information inside the source in one of the next versions? By
> >> this we can always blame Kopano if there is something not clear. :P

Sabre-dav was pulled in PHP's composer, which requires sabre/dav 1.8.12 (which pulls vobject in as dependency). There is talk here to maybe package it ourselves in a separate package.

> >> What about the other files until php/Files/Backend/Webdav, which license
> >> have the files and what is known about the copyright holder(s)?

Kopano wrote:

php/Files/Backend/Webdav/class.backend.php
php/Files/Backend/Webdav/cssloader.php
php/Files/Backend/Webdav/css/*

There is indeed no copyright information in the PHP files...

There is another library in there which is not in Debian, which is files/php/lib/phpfastcache.

> >> Unfortunately no information about that is visible inside the files.
> >> That's probably a thing the ftpmasters what to have clear. If the files
> >> in question are from Kopano please add some information about the
> >> license and the copyright holders inside the head of the files.
> > 
> > As discussed on #kcon17 please don't ship an embedded copy of
> > sabredav. We have 3.1 (experimental), 2.8 (testing/unstable/stable) and
> > 1.8 (oldstable) in Debian, one of them should fit.

Yup, would be saner, we need to package it for the rpm distro'
s then :)

> I like to stay on php-sabre-{dav,vobject}. Do we really need the vobject
> stuff? The package description says "library to parse and manipulate
> iCalendar and vCard objects" there this isn't really needed for files,
> isn't it? I didn't discovered any problems right now if I remove the
> vobject folder.

[jelle at starfighter][~/projects/kopano-webapp/plugins/files/php/Files/Backend/Webdav/sabredav/vendor/sabre/dav]%git grep -i vobject -- '*.php'
lib/Sabre/CalDAV/Backend/AbstractBackend.php:use Sabre\VObject;
lib/Sabre/CalDAV/Backend/AbstractBackend.php:        $vObject = VObject\Reader::read($data);

etc.

Since the dav library also supports caldav it needs vobject it is a dependency for the caldav library.

> We should no matter how add some autopkgtests to check if the php
> functions are available and usable, the php packages may chnage over
> time. But this needs someone with enough PHP knowledge, Jelle can you
> please show some basic practical test for this?

Sure I think some selenium tests would be good, iirc there where some for WebApp? Although one scenario I could think of would be create a webdav share with a file in it and check if it is shown. (slightly complicated though).