[Pkg-giraffe-discuss] kopano-webapp-plugin-files: various license information

[Carsten Schoenert]

Hello Jelle,

Am 02.10.2017 um 16:05 schrieb Jelle van der Waa:
...
> Sabre-dav was pulled in PHP's composer, which requires sabre/dav 
> 1.8.12 (which pulls vobject in as dependency). There is talk here to 
> maybe package it ourselves in a separate package.

I can live right now with the dependency on php-sabre-vobject. It brings
206kB of additional installed size.

>>>> What about the other files until php/Files/Backend/Webdav, which license
>>>> have the files and what is known about the copyright holder(s)?
> 
> Kopano wrote:
> 
> php/Files/Backend/Webdav/class.backend.php
> php/Files/Backend/Webdav/cssloader.php
> php/Files/Backend/Webdav/css/*
> 
> There is indeed no copyright information in the PHP files...

If Kopano could add some license information in some further changes
would really be helpful. Image the possibilities of other people which
look into the source. And the first person in Debian which will do that
are the ftpmasters.
Currently it would make my or our life a bit easier.

> There is another library in there which is not in Debian, which is
> files/php/lib/phpfastcache.
Yeah, I've seen and noticed that. phpfastcache isn't packaged yet so we
need to live with that. We should write a note about that embedded part
into README.source at some time.

[snip]
>> I like to stay on php-sabre-{dav,vobject}. Do we really need the vobject
>> stuff? The package description says "library to parse and manipulate
>> iCalendar and vCard objects" there this isn't really needed for files,
>> isn't it? I didn't discovered any problems right now if I remove the
>> vobject folder.
> 
> [jelle at starfighter][~/projects/kopano-webapp/plugins/files/php/Files/Backend/Webdav/sabredav/vendor/sabre/dav]%git grep -i vobject -- '*.php'
> lib/Sabre/CalDAV/Backend/AbstractBackend.php:use Sabre\VObject;
> lib/Sabre/CalDAV/Backend/AbstractBackend.php:        $vObject = VObject\Reader::read($data);
> 
> etc.
> 
> Since the dav library also supports caldav it needs vobject it is a
> dependency for the caldav library.
As written above, let us just live with the additional dependency.

>> We should no matter how add some autopkgtests to check if the php
>> functions are available and usable, the php packages may chnage over
>> time. But this needs someone with enough PHP knowledge, Jelle can you
>> please show some basic practical test for this?
> 
> Sure I think some selenium tests would be good, iirc there where
> some for WebApp? Although one scenario I could think of would be
> create a webdav share with a file in it and check if it is shown.
> (slightly complicated though).

Correct, we already have some selenium based test in kopano-webapp (were
I try right now to get the test working again).

https://anonscm.debian.org/cgit/pkg-giraffe/kopano-webapp.git/tree/debian/tests/test_webapp.py

We can probably use most of this code again. But I meant as a step
before simply check some PHP functions before this tests to ensure the
depending PHP packages can provide the needed functions.

But now let's finish the packaging first. I guess it looks not that bad.
If we are fine on the copyright file we can do a upload to NEW.


-- 
Regards
Carsten Schoenert