[Pkg-giraffe-maintainers] Bug#1021936: kopanocore: fix all arch ftbfs("error: ‘unique_ptr’ in namespace ‘std’ does not name a template type")

[Bo YU]

Source: kopanocore
Version: 8.7.0-7.2
Severity: important
Tags: ftbfs, sid, patch
X-Debbugs-Cc: tsu.yubo at gmail.com

Dear Maintainer,

The packages has all arch ftbfs issue due to 

```
                 from ../../tests/kc-335.cpp:8:
../../mapi4linux/include/kopano/memory.hpp:369:22: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
  369 |         typedef std::unique_ptr<T> single_object;
      |                      ^~~~~~~~~~
../../mapi4linux/include/kopano/memory.hpp:17:1: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
   16 | #include <kopano/ECTags.h>
  +++ |+#include <memory>
   17 | 
../../mapi4linux/include/kopano/memory.hpp:373:22: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
  373 |         typedef std::unique_ptr<T[]> array;
      |                      ^~~~~~~~~~
../../mapi4linux/include/kopano/memory.hpp:373:17: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
  373 |         typedef std::unique_ptr<T[]> array;
```

The full build log is here:
https://buildd.debian.org/status/fetch.php?pkg=kopanocore&arch=amd64&ver=8.7.0-7.2&stamp=1665834121&raw=0 (amd64 e,g)

The patch is try to fix the issue.

One point is that during dh_install, it will report:

```
dh_install
dh_install: warning: Cannot find (any matches for) "usr/lib/php" (tried in ., debian/tmp)

dh_install: warning: php-mapi missing files: usr/lib/php
dh_install: error: missing files, aborting

```

I think this is another issue[0] and I am not sure the way is right to deal
with it. Please double check here.

[0]: https://forum.kopano.io/topic/1928/8-7-80-missing-php-files-in-php-mapi-deb-package-ubuntu-16-04


-- 
Regards,
--
  Bo YU

-------------- next part --------------
diff -Nru kopanocore-8.7.0/debian/patches/add-memory-header.patch kopanocore-8.7.0/debian/patches/add-memory-header.patch
--- kopanocore-8.7.0/debian/patches/add-memory-header.patch	1970-01-01 07:30:00.000000000 +0730
+++ kopanocore-8.7.0/debian/patches/add-memory-header.patch	2020-12-10 05:02:13.000000000 +0800
@@ -0,0 +1,10 @@
+--- a/mapi4linux/include/kopano/memory.hpp
++++ b/mapi4linux/include/kopano/memory.hpp
+@@ -14,6 +14,7 @@
+ #include <edkmdb.h> /* ROWLIST */
+ #include <kopano/ECGuid.h>
+ #include <kopano/ECTags.h>
++#include <memory>
+ 
+ namespace KC {
+ 
diff -Nru kopanocore-8.7.0/debian/patches/series kopanocore-8.7.0/debian/patches/series
--- kopanocore-8.7.0/debian/patches/series	2020-12-10 05:01:33.000000000 +0800
+++ kopanocore-8.7.0/debian/patches/series	2020-12-10 05:02:13.000000000 +0800
@@ -32,3 +32,4 @@
 dbadm-add-corrective-procedure-for-bug-KC-1444.patch
 freebusy-avoid-out-of-bounds-access-in-HrAddFBBlock.patch
 fix-build.patch
+add-memory-header.patch
diff -Nru kopanocore-8.7.0/debian/php-mapi.install.in kopanocore-8.7.0/debian/php-mapi.install.in
--- kopanocore-8.7.0/debian/php-mapi.install.in	2018-12-22 04:11:16.000000000 +0800
+++ kopanocore-8.7.0/debian/php-mapi.install.in	2020-12-10 05:02:13.000000000 +0800
@@ -1,3 +1,3 @@
 etc/php/*/cli/conf.d/mapi.ini /etc/php/@PHP_VERSION@/mods-available
 usr/share/kopano/php/mapi/
-usr/lib/php
+#usr/lib/php
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-giraffe-maintainers/attachments/20221017/6881e059/attachment.sig>