Bug#260192: gedit: PATCH: premature free in egg-recent-view-gtk.c

Sebastien Bacher Sebastien Bacher <seb128@debian.org>, 260192@bugs.debian.org
Mon, 02 Aug 2004 00:18:00 +0200


Le lundi 19 juillet 2004 =E0 19:16 +1000, Peter Moulder a =E9crit :

> In egg_recent_view_gtk_new_menu_item, uri is passed to
> egg_recent_util_get_icon after already being freed.
>=20
> uri is subsequently passed to, and presumably read by, gnome_icon_lookup.
> This will typically result in the wrong icon being shown (e.g. no icon),
> or conceivably result in segfault from reading unmapped memory.
>=20
> Patch appended.

Hi,

Thanks for the patch. It's supposed to get working icons in the file
menu for the recents files, right ? In fact I've no icon in this menu,
but the patch doesn't solve the issue. Does it fixes the problem on your
box ? I'll try to have a look on this soon.


Cheers,

Sebastien Bacher