Bug#258786: marked as done (gnome-terminal: FTBFS with gcc-3.4: conflicting types for 'egg_cell_renderer_keys_set_accelerator')

Debian Bug Tracking System owner@bugs.debian.org
Fri, 19 Nov 2004 22:33:06 -0800


Your message dated Sat, 20 Nov 2004 07:28:00 +0100
with message-id <20041120062800.GA19608@andaco.de>
and subject line Bug#258786: Acknowledgement (gnome-terminal: FTBFS with gcc-3.4: conflicting types for 'egg_cell_renderer_keys_set_accelerator')
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Jul 2004 12:47:08 +0000
>From aj@andaco.de Sun Jul 11 05:47:08 2004
Return-path: <aj@andaco.de>
Received: from c147245.adsl.hansenet.de (localhost) [213.39.147.245] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BjdjX-0006ZI-00; Sun, 11 Jul 2004 05:47:07 -0700
Received: from aj by localhost with local (Exim 4.34)
	id 1BjdjV-0007Td-U5; Sun, 11 Jul 2004 14:47:05 +0200
To: Debian Bug Tracking System <submit@bugs.debian.org>
From: Andreas Jochens <aj@andaco.de>
Subject: gnome-terminal: FTBFS with gcc-3.4: conflicting types for 'egg_cell_renderer_keys_set_accelerator'
Message-Id: <E1BjdjV-0007Td-U5@localhost>
Date: Sun, 11 Jul 2004 14:47:05 +0200
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Package: gnome-terminal
Severity: normal
Tags: patch

When building 'gnome-terminal' with gcc-3.4 I get the following error:

cc -DHAVE_CONFIG_H -I. -I. -I.. -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/startup-notification-1.0   	-DTERM_LOCALEDIR=\"/usr/share/locale\" -DEXECUTABLE_NAME=\"gnome-terminal\" 	-DTERM_GLADE_DIR=\"/usr/share/gnome-terminal/glade\" 	-DTERM_GLADE_FILE=\"gnome-terminal.glade2\" 	-DTERM_DATADIR=\"/usr/share\" 	-DTERM_LIBDIR=\"/usr/lib\" 	-DTERM_PREFIX=\"/usr\" 	-DTERM_SYSCONFDIR=\"/etc\" 	-DTERM_PKGDATADIR=\"/usr/share/gnome-terminal\" 	-DGDK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED		-DGNOME_DISABLE_DEPRECATED 	-DSN_API_NOT_YET_FROZEN    -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/startup-notification-1.0   -g -Wall -O2 -c simple-x-font-selector.c
cc -DHAVE_CONFIG_H -I. -I. -I.. -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/startup-notification-1.0   	-DTERM_LOCALEDIR=\"/usr/share/locale\" -DEXECUTABLE_NAME=\"gnome-terminal\" 	-DTERM_GLADE_DIR=\"/usr/share/gnome-terminal/glade\" 	-DTERM_GLADE_FILE=\"gnome-terminal.glade2\" 	-DTERM_DATADIR=\"/usr/share\" 	-DTERM_LIBDIR=\"/usr/lib\" 	-DTERM_PREFIX=\"/usr\" 	-DTERM_SYSCONFDIR=\"/etc\" 	-DTERM_PKGDATADIR=\"/usr/share/gnome-terminal\" 	-DGDK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED		-DGNOME_DISABLE_DEPRECATED 	-DSN_API_NOT_YET_FROZEN    -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/startup-notification-1.0   -g -Wall -O2 -c eggaccelerators.c
cc -DHAVE_CONFIG_H -I. -I. -I.. -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/startup-notification-1.0   	-DTERM_LOCALEDIR=\"/usr/share/locale\" -DEXECUTABLE_NAME=\"gnome-terminal\" 	-DTERM_GLADE_DIR=\"/usr/share/gnome-terminal/glade\" 	-DTERM_GLADE_FILE=\"gnome-terminal.glade2\" 	-DTERM_DATADIR=\"/usr/share\" 	-DTERM_LIBDIR=\"/usr/lib\" 	-DTERM_PREFIX=\"/usr\" 	-DTERM_SYSCONFDIR=\"/etc\" 	-DTERM_PKGDATADIR=\"/usr/share/gnome-terminal\" 	-DGDK_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED		-DGNOME_DISABLE_DEPRECATED 	-DSN_API_NOT_YET_FROZEN    -DXTHREADS -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/startup-notification-1.0   -g -Wall -O2 -c eggcellrendererkeys.c
eggcellrendererkeys.c:588: error: conflicting types for 'egg_cell_renderer_keys_set_accelerator'
eggcellrendererkeys.h:73: error: previous declaration of 'egg_cell_renderer_keys_set_accelerator' was here
eggcellrendererkeys.c:588: error: conflicting types for 'egg_cell_renderer_keys_set_accelerator'
eggcellrendererkeys.h:73: error: previous declaration of 'egg_cell_renderer_keys_set_accelerator' was here
eggcellrendererkeys.c:630: error: conflicting types for 'egg_cell_renderer_keys_get_accelerator'
eggcellrendererkeys.h:76: error: previous declaration of 'egg_cell_renderer_keys_get_accelerator' was here
eggcellrendererkeys.c:630: error: conflicting types for 'egg_cell_renderer_keys_get_accelerator'
eggcellrendererkeys.h:76: error: previous declaration of 'egg_cell_renderer_keys_get_accelerator' was here
make[4]: *** [eggcellrendererkeys.o] Error 1
make[4]: Leaving directory `/gnome-terminal-2.6.1/src'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/gnome-terminal-2.6.1/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/gnome-terminal-2.6.1'
make[1]: *** [all-recursive-am] Error 2
make[1]: Leaving directory `/gnome-terminal-2.6.1'
make: *** [debian/stamp-makefile-build] Error 2

With the attached patch 'gnome-terminal' can be compiled using gcc-3.4.

Regards
Andreas Jochens

diff -urN ../tmp-orig/gnome-terminal-2.6.1/src/eggcellrendererkeys.c ./src/eggcellrendererkeys.c
--- ../tmp-orig/gnome-terminal-2.6.1/src/eggcellrendererkeys.c	2003-07-03 15:31:10.000000000 +0200
+++ ./src/eggcellrendererkeys.c	2004-07-11 14:26:25.451535129 +0200
@@ -584,7 +584,7 @@
 void
 egg_cell_renderer_keys_set_accelerator (EggCellRendererKeys *keys,
                                         guint                keyval,
-                                        GdkModifierType      mask)
+                                        EggVirtualModifierType mask)
 {
   char *text;
   gboolean changed;
@@ -626,7 +626,7 @@
 void
 egg_cell_renderer_keys_get_accelerator (EggCellRendererKeys *keys,
                                         guint               *keyval,
-                                        GdkModifierType     *mask)
+                                        EggVirtualModifierType *mask)
 {
   g_return_if_fail (EGG_IS_CELL_RENDERER_KEYS (keys));
 

---------------------------------------
Received: (at 258786-done) by bugs.debian.org; 20 Nov 2004 06:28:00 +0000
>From aj@andaco.de Fri Nov 19 22:28:00 2004
Return-path: <aj@andaco.de>
Received: from c211052.adsl.hansenet.de (aj.andaco.de) [213.39.211.52] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CVOj2-0004Qv-00; Fri, 19 Nov 2004 22:28:00 -0800
Received: from aj by aj.andaco.de with local (Exim 4.34)
	id 1CVOj2-00056R-FL; Sat, 20 Nov 2004 07:28:00 +0100
Date: Sat, 20 Nov 2004 07:28:00 +0100
To: 258786-done@bugs.debian.org
Subject: Re: Bug#258786: Acknowledgement (gnome-terminal: FTBFS with gcc-3.4: conflicting types for 'egg_cell_renderer_keys_set_accelerator')
Message-ID: <20041120062800.GA19608@andaco.de>
References: <E1BjdjV-0007Td-U5@localhost> <handler.258786.B.108955002825274.ack@bugs.debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <handler.258786.B.108955002825274.ack@bugs.debian.org>
User-Agent: Mutt/1.5.6+20040907i
From: Andreas Jochens <aj@andaco.de>
Delivered-To: 258786-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

This bug has been fixed with the new upstream version 2.8.0.

Regards
Andreas Jochens