Bug#493210: Patch

Matt Kraai kraai at ftbfs.org
Fri Aug 1 17:47:52 UTC 2008


tag 493210 patch
thanks

The problem is caused by the if condition in the following code: 

	if (arg_list)
		message = g_strdup_vprintf (format, arg_list);
	else
		message = g_strdup (format);

It should be safe to remove this check unless there are cases where
format contains a format tag and arg_list is zero, but I doubt there
would be.

-- 
Matt                                                 http://ftbfs.org/
-------------- next part --------------
diff -ru brasero-0.8.0~/src/burn-session.c brasero-0.8.0/src/burn-session.c
--- brasero-0.8.0~/src/burn-session.c	2008-08-01 10:24:52.000000000 -0700
+++ brasero-0.8.0/src/burn-session.c	2008-08-01 10:25:19.000000000 -0700
@@ -1438,10 +1438,7 @@
 	if (!priv->session)
 		return;
 
-	if (arg_list)
-		message = g_strdup_vprintf (format, arg_list);
-	else
-		message = g_strdup (format);
+	message = g_strdup_vprintf (format, arg_list);
 
 	/* we also need to validate the messages to be in UTF-8 */
 	if (!g_utf8_validate (message, -1, (const gchar**) &offending))


More information about the pkg-gnome-maintainers mailing list