Bug#643423: libgksu: FTBFS: libgksu.c:1279:7: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: libgksu
Version: 2.0.13~pre1-4
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
> /bin/bash ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/startup-notification-1.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libgtop-2.0   -DLOCALEDIR=\"/usr/share/locale\" -DDATA_DIR=\"/usr/share\" -DPREFIX=\"/usr\"   -g -O2 -Wall -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c -o libgksu.lo libgksu.c
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -pthread -DORBIT2=1 -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/startup-notification-1.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libgtop-2.0 -DLOCALEDIR=\"/usr/share/locale\" -DDATA_DIR=\"/usr/share\" -DPREFIX=\"/usr\" -g -O2 -Wall -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c libgksu.c  -fPIC -DPIC -o .libs/libgksu.o
> libgksu.c: In function 'sudo_prepare_xauth':
> libgksu.c:1279:7: error: format not a string literal and no format arguments [-Werror=format-security]
> libgksu.c: In function 'gksu_su_fuller':
> libgksu.c:2250:8: error: format not a string literal and no format arguments [-Werror=format-security]
> libgksu.c: In function 'gksu_sudo_fuller':
> libgksu.c:2982:3: error: format not a string literal and no format arguments [-Werror=format-security]
> libgksu.c:2844:10: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2846:10: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c: In function 'read_line':
> libgksu.c:2392:12: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c: In function 'gksu_su_fuller':
> libgksu.c:2061:9: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2115:14: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2116:14: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2194:14: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2198:14: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2202:14: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2210:13: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c:2265:9: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
> libgksu.c: In function 'get_xauth_token':
> libgksu.c:1121:9: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
> cc1: some warnings being treated as errors
> 
> make[3]: *** [libgksu.lo] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/libgksu_2.0.13~pre1-4_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.