Bug#643424: libgnomecups: FTBFS: gnome-cups-request.c:356:10: error: format not a string literal and no format arguments [-Werror=format-security]

[Didier Raboud]

Source: libgnomecups
Version: 0.2.3-3
Severity: serious
Tags: wheezy sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20110923 qa-ftbfs hardening-format-security hardening
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part:
>  gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I.. -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DDATADIR=\"/usr/share\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security -Wall -c gnome-cups-request.c  -fPIC -DPIC -o .libs/gnome-cups-request.o
> gnome-cups-request.c: In function 'request_thread_main':
> gnome-cups-request.c:356:10: error: format not a string literal and no format arguments [-Werror=format-security]
> gnome-cups-request.c:367:9: error: format not a string literal and no format arguments [-Werror=format-security]
> gnome-cups-request.c:375:2: warning: value computed is not used [-Wunused-value]
> gnome-cups-request.c: In function 'gnome_cups_request_add_requested_attributes':
> gnome-cups-request.c:469:10: warning: passing argument 7 of 'ippAddStrings' from incompatible pointer type [enabled by default]
> /usr/include/cups/ipp.h:460:25: note: expected 'const char * const*' but argument is of type 'char **'
> cc1: some warnings being treated as errors
> 
> make[3]: *** [gnome-cups-request.lo] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2011/09/23/libgnomecups_0.2.3-3_lsid64.buildlog

This happened because since dpkg 1.16.0 [0], hardening flags are enabled 
under various conditions.

[0] http://lists.debian.org/debian-devel-announce/2011/09/msg00001.html

A list of current common problems and possible solutions is available at 
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on about 50 AMD64 nodes
of the Grid'5000 platform, using a clean chroot.  Internet was not
accessible from the build systems.