Bug#728140: Aisleriot FTBFS on raspbian and likely any other similar derivative.

[peter green]

Package: aisleriot
Tags: patch

The upstream configure script determines the "pysol card themes base 
path" with the following logic.

if test -f /etc/os-release; 
then                                                                                                           

  DISTRO="$(source /etc/os-release && echo 
$ID)"                                                                                           

else                                                                                                                                       

  
DISTRO="unknown"                                                                                                                         

fi
<--snip-->

# Check whether --with-pysol-card-theme-path was 
given.                                                                                    

if test "${with_pysol_card_theme_path+set}" = set; then 
:                                                                                  

  
withval=$with_pysol_card_theme_path;                                                                                                     

else                                                                                                                                       

  case "$DISTRO" 
in                                                                                                                        

          debian|ubuntu) 
with_pysol_card_theme_path="/usr/share/games/pysol" 
;;                                                           
          fedora|rhel|centos) 
with_pysol_card_theme_path="/usr/share/PySolFC" 
;;                                                          
          opensuse) 
with_pysol_card_theme_path="/usr/share/games/pysol/data" 
;;                                                           
          *) as_fn_error $? "When enabling the PySol card theme format, 
you must specify the PySol card themes base path." "$LINENO" 5 ;; 
        
esac                                                                                                                               

fi

The trouble is that this method of detecting distro's has no ideas of 
"derivatives" or "distro families" or similar. The result is when the 
package is built on raspbian it detects the distro name as "raspbian", 
doesn't recognise that name and fails.

There is similar code for the "kde card theme format" but that doesn't 
seem to be enabled in the debian package.

Possible fixes:
1: force the "pysol card themes base path" in the debian packaging. This 
should make the aisleriot debian package build on raspbian and any 
similar derivatives but obviously won't help those who build directly 
from upstream sources. This is what we have done locally in raspbian for 
the moment (see attatched debdiff).
2: add raspbian to the list of distros in the configure script and push 
that change upstream. This would fix the issue for builds on raspbian 
whether from debian packages but wouldn't help users of other derivatives.
3: Modify the configure script to look at the ID_LIKE* field in 
/etc/os_version if ID doesn't match any known distro. Complicating this 
is that ID_LIKE may contain multiple entries all of which would 
probablly need to be checked against the "list of known distros".

* http://www.freedesktop.org/software/systemd/man/os-release.html
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: aisleriot.debdiff
URL: <http://lists.alioth.debian.org/pipermail/pkg-gnome-maintainers/attachments/20131028/d665a493/attachment-0002.ksh>