Bug#728140: Aisleriot FTBFS on raspbian and likely any other similar derivative.

[Emilio Pozuelo Monfort]

On 28/10/13 21:00, peter green wrote:
> Package: aisleriot
> Tags: patch
> 
> The upstream configure script determines the "pysol card themes base path" with
> the following logic.
> 
> if test -f /etc/os-release;
> then                                                                                                          
> 
>  DISTRO="$(source /etc/os-release && echo
> $ID)"                                                                                          
> 
> else                                                                                                                                      
> 
>  
> DISTRO="unknown"                                                                                                                        
> 
> fi
> <--snip-->
> 
> # Check whether --with-pysol-card-theme-path was
> given.                                                                                   
> 
> if test "${with_pysol_card_theme_path+set}" = set; then
> :                                                                                 
>  
> withval=$with_pysol_card_theme_path;                                                                                                    
> 
> else                                                                                                                                      
> 
>  case "$DISTRO"
> in                                                                                                                       
> 
>          debian|ubuntu) with_pysol_card_theme_path="/usr/share/games/pysol"
> ;;                                                                   
> fedora|rhel|centos) with_pysol_card_theme_path="/usr/share/PySolFC"
> ;;                                                                   opensuse)
> with_pysol_card_theme_path="/usr/share/games/pysol/data"
> ;;                                                                    *)
> as_fn_error $? "When enabling the PySol card theme format, you must specify the
> PySol card themes base path." "$LINENO" 5 ;;       
> esac                                                                                                                              
> 
> fi
> 
> The trouble is that this method of detecting distro's has no ideas of
> "derivatives" or "distro families" or similar. The result is when the package is
> built on raspbian it detects the distro name as "raspbian", doesn't recognise
> that name and fails.
> 
> There is similar code for the "kde card theme format" but that doesn't seem to
> be enabled in the debian package.
> 
> Possible fixes:
> 1: force the "pysol card themes base path" in the debian packaging. This should
> make the aisleriot debian package build on raspbian and any similar derivatives
> but obviously won't help those who build directly from upstream sources. This is
> what we have done locally in raspbian for the moment (see attatched debdiff).

That sounds reasonable to me, patch applied in svn for the next upload.

Building directly from upstream sources is still possible, people just need to
pass --with-pysol-card-theme-path. If you want to go for 2 (or 3) as well that's
fine, just do so upstream.

Emilio

> 2: add raspbian to the list of distros in the configure script and push that
> change upstream. This would fix the issue for builds on raspbian whether from
> debian packages but wouldn't help users of other derivatives.
> 3: Modify the configure script to look at the ID_LIKE* field in /etc/os_version
> if ID doesn't match any known distro. Complicating this is that ID_LIKE may
> contain multiple entries all of which would probablly need to be checked against
> the "list of known distros".
> 
> * http://www.freedesktop.org/software/systemd/man/os-release.html
> 
> 
> _______________________________________________
> pkg-gnome-maintainers mailing list
> pkg-gnome-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-gnome-maintainers
>