Bug#558581: Missing autoreconf to fix 554821 or similar bugs in the future

[Andreas Barth]

Control: severity -1 important
Control: tags -1 + patch

Hi,

* Peter Fritzsche (peter.fritzsche at gmx.de) [140907 11:01]:
> [...]

this topic becomes now more important because it blocks the package from being
built on ppc64el, which in turn block xfce4-panel.

The usual fix of just adding cdbs/autoreconf does not work because autoreconf
adds a couple of -Werror, so the build fails with

| libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/startup-notification-1.0 -I.. -DWNCK_I_KNOW_THIS_IS_UNSTABLE -DWNCK_LOCALEDIR=\"/usr/share/locale\" -DG_LOG_DOMAIN=\"Wnck\" -DSN_API_NOT_YET_FROZEN=1 -D_FORTIFY_SOURCE=2 -Wall -Wstrict-prototypes -Wnested-externs -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=format-security -Werror=format=2 -Werror=missing-include-dirs -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -c tasklist.c  -fPIC -DPIC -o .libs/libwnck_1_la-tasklist.o
| In file included from /usr/include/gtk-2.0/gtk/gtk.h:234:0,
|                  from tasklist.h:27,
|                  from tasklist.c:34:
| /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
|  typedef void (*GtkItemFactoryCallback)  ();
|  ^
| tasklist.c:990:6: error: no previous prototype for 'wnck_tasklist_set_orientation' [-Werror=missing-prototypes]
|  void wnck_tasklist_set_orientation(WnckTasklist *tasklist, GtkOrientation orient)
|       ^
| tasklist.c: In function 'wnck_task_expose':
| tasklist.c:4179:16: warning: variable 'dgc' set but not used [-Wunused-but-set-variable]
|    GdkGC *lgc, *dgc;
|                 ^
| tasklist.c:4179:10: warning: variable 'lgc' set but not used [-Wunused-but-set-variable]
|    GdkGC *lgc, *dgc;
|           ^
| cc1: some warnings being treated as errors
| Makefile:820: recipe for target 'libwnck_1_la-tasklist.lo' failed


Adding -Wno-error=missing-prototypes to CFLAGS fixes this (and I think
that this is acceptable, because it didn't fail on that before
either, so it's not worse, and we get a bunch of other Werrors for basic
things).

diff -u -r ../libwnck-2.30.7~/debian/rules ../libwnck-2.30.7/debian/rules
--- ../libwnck-2.30.7~/debian/rules     2011-10-15 18:29:11.000000000 +0000
+++ ../libwnck-2.30.7/debian/rules      2014-09-08 13:33:02.354108129 +0000
@@ -1,5 +1,6 @@
 #!/usr/bin/make -f
 
+include /usr/share/cdbs/1/rules/autoreconf.mk
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/rules/utils.mk
 include /usr/share/cdbs/1/class/gnome.mk
@@ -9,6 +10,7 @@
 -include /usr/share/gnome-pkg-tools/1/rules/gnome-get-source.mk
 
 LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
+CFLAGS += -Wno-error=missing-prototypes
 
 DEB_CONFIGURE_EXTRA_FLAGS += \
        --disable-gtk-doc \


Does this patch look ok? If so, do you want to upload it, or would an NMU be
helpful?


Andi