Bug#1077690: gtk4: intended CFLAGS/LDFLAGS no longer set, leading to test failures and FTBFS on i386

[Simon McVittie]

On Wed, 31 Jul 2024 at 23:02:31 +0100, Simon McVittie wrote:
> On Thu, 01 Aug 2024 at 00:19:45 +0300, Adrian Bunk wrote:
> > Comparing build logs the "-Wl,-z,defs -Wl,-O1" is also gone
> > (not only on i386)

Are you sure those LDFLAGS are missing? I can see the -Wl,-O1 showing up
in the build log when Meson links libraries and executables (search for
"cc  -o", with two spaces; I checked the amd64 and i386 logs).

(The -Wl,-z,defs is also there, but that isn't necessarily useful evidence
because the upstream build system also adds it.)

It's possible that it's missing when g-ir-scanner links its "dumper", but
that isn't actually important anyway, because it's run once to parse its
output and then thrown away - it isn't installed.

I think the difference is that I tried to add the CFLAGS for i386 the "new"
way, via DEB_CFLAGS_MAINT_APPEND, but the LDFLAGS are set the "old" way,
by importing dpkg's default.mk and then appending with "LDFLAGS += ...".

As I said, this worked at the weekend (including the addition of
-ffloat-store on i386), so it must be something that changed rather
recently.