Bug#1077690: gtk4: intended CFLAGS/LDFLAGS no longer set, leading to test failures and FTBFS on i386

[Adrian Bunk]

On Wed, Jul 31, 2024 at 11:21:51PM +0100, Simon McVittie wrote:
> On Wed, 31 Jul 2024 at 23:02:31 +0100, Simon McVittie wrote:
> > On Thu, 01 Aug 2024 at 00:19:45 +0300, Adrian Bunk wrote:
> > > Comparing build logs the "-Wl,-z,defs -Wl,-O1" is also gone
> > > (not only on i386)
> 
> Are you sure those LDFLAGS are missing? I can see the -Wl,-O1 showing up
> in the build log when Meson links libraries and executables (search for
> "cc  -o", with two spaces; I checked the amd64 and i386 logs).

Sorry, I got that backwards.

LDFLAGS were missing with dpkg 1.22.9 in gtk4 4.14.4+ds-4 but are now back.

>...
> I think the difference is that I tried to add the CFLAGS for i386 the "new"
> way, via DEB_CFLAGS_MAINT_APPEND, but the LDFLAGS are set the "old" way,
> by importing dpkg's default.mk and then appending with "LDFLAGS += ...".
> 
> As I said, this worked at the weekend (including the addition of
> -ffloat-store on i386), so it must be something that changed rather
> recently.

I just tested, and dpkg 1.22.9 -> 1.22.10 is the relevant difference.

What works with both versions is
  -DEB_CFLAGS_MAINT_APPEND = -ffloat-store
  +export DEB_CFLAGS_MAINT_APPEND = -ffloat-store

Apparently the now reverted dpkg changes worked with not exported 
_APPEND variables?

cu
Adrian