[Pkg-gnupg-maint] Bug#737128: gpg exits with a fatal error about missing trustdb despite successfully having imported a key

[Thijs Kinkhorst]

Package: gnupg
Version: 1.4.16-1
Tags: patch

---------------------------- Original Message ----------------------------
Subject: Re: [FOSDEM] Keysigning: list of participants now available
From:    "Philip Paeps" <philip at fosdem.org>
Date:    Thu, January 30, 2014 12:21
To:      "gregor herrmann" <gregor+fosdem at comodo.priv.at>
Cc:      "fosdem at lists.fosdem.org visitors" <fosdem at lists.fosdem.org>
--------------------------------------------------------------------------

On 29 Jan 2014, at 22:19, gregor herrmann <gregor+fosdem at comodo.priv.at>
wrote:
> On Tue, 28 Jan 2014 08:53:17 -0600, Tom Marble wrote:
>> Please use caff(1) from the package signing-party (after the KSP)
>> to sign the keys at home.  But BEWARE the default caff configuration
>> is NOT the same as for GPG.  Please make sure you are using the
>> configuration settings you intend (esp. strong signature strength).
>> For more information please see:
>>  https://github.com/tmarble/kspsig
>
> Please be aware of http://bugs.debian.org/735536 when using caff.

This patch against gnupg-1.4.16 fixes it.

When importing keys with --trust-model=always and no existing trustdb,
gpg would exit with a fatal error about the missing trustdb despite
successfully having imported the key.  We should not exit with a fatal
error when an operation completes successfully!

Signed-off-by: Philip Paeps <philip at paeps.cx>
---
g10/trustdb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/g10/trustdb.c b/g10/trustdb.c
index 0bf92e4..f0c0ab8 100644
--- a/g10/trustdb.c
+++ b/g10/trustdb.c
@@ -927,6 +927,7 @@ clear_ownertrusts (PKT_public_key *pk)
  TRUSTREC rec;
  int rc;

+  init_trustdb();
  if (trustdb_args.no_trustdb && opt.trust_model == TM_ALWAYS)
    return 0;

-- 
1.8.3.4 (Apple Git-47)

Philip

-- 
Philip Paeps
Senior Reality Engineer
Ministry of Information

_______________________________________________
FOSDEM mailing list
FOSDEM at lists.fosdem.org
https://lists.fosdem.org/listinfo/fosdem