[Debian GNUstep maintainers] Bug#749758: lusernet.app: GCC warnings that may lead to runtime issues with new GNUstep libraries

Thu May 29 16:41:21 UTC 2014

Source: lusernet.app
Version: 0.4.2-6.1
Severity: normal
Tags: sid jessie
User: pkg-gnustep-maintainers at lists.alioth.debian.org
Usertags: gnustep-base1.24-transition gnustep-gui0.24-transition gnustep-transition

Your package builds successfully with the new GNUstep libraries, but
there are some GCC warnings that *may* lead to problems at runtime and
may affect the forthcoming gnustep transition/jessie release.  Latest
versions of the core GNUstep packages are available at mentors.d.n [*];
they will be uploaded to experimental first.

Please note that the warnings may be unrelated to GNUstep or changes in
GNUstep but could be legitimate nevertheless.  In case the fix is
applicable for the current gnustep-* library packages in sid (-base/1.22
and -gui/0.20) you can upload the fixed package before the transition
begins.  Otherwise, please wait for the transition to complete and
do not forget to adjust the Build-Depends field accordingly:

  libgnustep-base-dev (>= 1.24.6)
  or
  libgnustep-gui-dev (>= 0.24)

Relevant portion(s) of the log:

NNTPServer.m: In function '-[NNTPServer(private) nc:connect:]':
NNTPServer.m:592:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    [runloop addEvent: (void *)c->sock type: ET_RDESC watcher: self
                       ^
NNTPServer.m:594:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    [runloop addEvent: (void *)c->sock type: ET_EDESC watcher: self
                       ^
NNTPServer.m: In function '-[NNTPServer(private) nc:update:]':
NNTPServer.m:613:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    [runloop removeEvent: (void *)c->sock type: ET_WDESC
                          ^
NNTPServer.m:621:23: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    [runloop addEvent: (void *)c->sock type: ET_WDESC watcher: self
                       ^
NNTPServer.m: In function '-[NNTPServer(private) nc:free:]':
NNTPServer.m:686:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    [runloop removeEvent: (void *)c->sock type: ET_RDESC
                          ^
NNTPServer.m:688:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    [runloop removeEvent: (void *)c->sock type: ET_WDESC
                          ^
NNTPServer.m:690:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
    [runloop removeEvent: (void *)c->sock type: ET_EDESC
                          ^
NNTPServer.m: In function '-[NNTPServer(private) nc:parseResponse:]':
NNTPServer.m:743:3: warning: pointer targets in passing argument 1 of 'atoi' differ in signedness [-Wpointer-sign]
   cn->resp_code=atoi(cn->resp_buf);
   ^
In file included from /usr/include/GNUstep/GNUstepBase/GSConfig.h:397:0,
                 from /usr/include/GNUstep/GNUstepBase/GSVersionMacros.h:219,
                 from /usr/include/GNUstep/Foundation/NSException.h:33,
                 from NNTPServer.m:15:
/usr/include/stdlib.h:278:42: note: expected 'const char *' but argument is of type 'unsigned char *'
 __NTH (atoi (const char *__nptr))
                                          ^
NNTPServer.m:831:17: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
      list[num++]=d;
                 ^
NNTPServer.m: In function '-[NNTPServer(private) nc:updateRead:]':
NNTPServer.m:958:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     [runloop removeEvent: (void *)c->sock type: ET_RDESC
                           ^
NNTPServer.m:960:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     [runloop removeEvent: (void *)c->sock type: ET_EDESC
                           ^
NNTPServer.m:962:27: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     [runloop removeEvent: (void *)c->sock type: ET_WDESC
                           ^
NNTPServer.m: In function '-[NNTPServer(private) nc:writeData:::]':
NNTPServer.m:1050:18: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
  c->write_pending=data;
                  ^
NNTPServer.m: In function '-[NNTPServer(private) receivedEvent:type:extra:forMode:]':
NNTPServer.m:1069:4: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  j=(int)data;
    ^
NNTPServer.m: In function '-[NNTPServer(private) nc:updateState:]':
NNTPServer.m:1260:7: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
    d=b=c->resp_buf;
       ^
[...]
MsgDB.m: In function '-[MsgDB msg:getData:length::]':
MsgDB.m:934:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
   *data=m->data;
        ^
MsgDB.m: In function '-[MsgDB setMessageData:length::]':
MsgDB.m:972:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
  m->data=d;
         ^
MsgDB.m:988:4: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
   b=m->data;
    ^
[...]
main.m: In function '-[AppDelegate composeFollowupToMessage:]':
main.m:76:2: warning: passing argument 1 of 'initWithFollowupToMessage:' from distinct Objective-C type [enabled by default]
  [[[ComposeWindowController alloc] initWithFollowupToMessage: msg] showWindow: self];
  ^
[...]
MessageViewController.m: In function '-[MessageViewController(private) _render:multipart:type:to:]':
MessageViewController.m:227:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   if (cur_options && (disp=(int)NSMapGet(cur_options,mp)))
                            ^
MessageViewController.m: In function '-[MessageViewController(private) _renderContent:parent:to:]':
MessageViewController.m:410:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   if (cur_options && ((int)NSMapGet(cur_options,p))==1)
                       ^
MessageViewController.m:425:22: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  if (cur_options && ((int)NSMapGet(cur_options,p))==2)
                      ^
MessageViewController.m:470:13: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   else if (((int)NSMapGet(cur_options,p))==2)
             ^
MessageViewController.m: In function '-[MessageViewController textView:clickedOnLink:atIndex:]':
MessageViewController.m:805:37: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
   NSMapInsert(cur_options,l->object,(void *)l->value);
                                     ^
MessageViewController.m:814:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   if (((int)NSMapGet(cur_options,l->object))==1)
        ^
MessageViewController.m:825:8: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   if (((int)NSMapGet(cur_options,l->object))==2)
        ^

The full build log is available upon request.
The severity of this bug may be raised to "important", "serious" or
"grave" after the transition depending on the impact.

[*]
http://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.6-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-base/gnustep-base_1.24.6-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-gui/gnustep-gui_0.24.0-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-back/gnustep-back_0.24.0-1.dsc