[Debian GNUstep maintainers] Bug#749760: lynkeos.app: GCC warnings that may lead to runtime issues with new GNUstep libraries

Thu May 29 16:50:05 UTC 2014

Source: lynkeos.app
Version: 1.2-6.2
Severity: normal
Tags: sid jessie
User: pkg-gnustep-maintainers at lists.alioth.debian.org
Usertags: gnustep-base1.24-transition gnustep-gui0.24-transition gnustep-transition

Your package builds successfully with the new GNUstep libraries, but
there are some GCC warnings that *may* lead to problems at runtime and
may affect the forthcoming gnustep transition/jessie release.  Latest
versions of the core GNUstep packages are available at mentors.d.n [*];
they will be uploaded to experimental first.

Please note that the warnings may be unrelated to GNUstep or changes in
GNUstep but could be legitimate nevertheless.  In case the fix is
applicable for the current gnustep-* library packages in sid (-base/1.22
and -gui/0.20) you can upload the fixed package before the transition
begins.  Otherwise, please wait for the transition to complete and
do not forget to adjust the Build-Depends field accordingly:

  libgnustep-base-dev (>= 1.24.6)
  or
  libgnustep-gui-dev (>= 0.24)

Relevant portion(s) of the log:

ffmpeg_access.c: In function 'ffmpegLoadMovie':
ffmpeg_access.c:274:14: warning: assignment from incompatible pointer type [enabled by default]
     pCodecCtx=&pFormatCtx->streams[videoStream]->codec;
              ^
[...]
ffmpeg_access.c:321:5: warning: implicit declaration of function 'asprintf' [-Wimplicit-function-declaration]
     size = asprintf(&ppmHeader,"P6 %d %d 255\n",pCodecCtx->width, pCodecCtx->height);
     ^
[...]
main.m: In function 'main':
main.m:59:3: warning: implicit declaration of function 'ffmpegInit' [-Wimplicit-function-declaration]
   ffmpegInit();
   ^
main.m:62:3: warning: implicit declaration of function 'NSApplicationMain' [-Wimplicit-function-declaration]
   return NSApplicationMain(argc, argv);
   ^
[...]
MyDocument.m: In function '-[MyDocument deleteEntry:]':
MyDocument.m:538:7: warning: passing argument 1 of 'setStack:size:' from incompatible pointer type [enabled by default]
       [list setStack:nil size:0];
       ^
MyDocument.m:538:7: note: expected 'struct RGB *' but argument is of type 'id'
MyDocument.m: In function '-[MyDocument saveStackedImage:]':
MyDocument.m:970:6: warning: passing argument 1 of 'saveTIFFPictureToFile' discards 'const' qualifier from pointer target type [enabled by default]
      saveTIFFPictureToFile([[panel filename]  cString],plane[0],w,h);
      ^
In file included from LynkeosFfmpegMovie.h:7:0,
                 from MyImageListItem.h:38,
                 from MyDocument.h:31,
                 from MyDocument.m:33:
ffmpeg_access.h:25:5: note: expected 'char *' but argument is of type 'const char *'
 int saveTIFFPictureToFile(char* fileName,char* buffer,unsigned int width, unsigned int height);
     ^
MyDocument.m:970:6: warning: pointer targets in passing argument 2 of 'saveTIFFPictureToFile' differ in signedness [-Wpointer-sign]
      saveTIFFPictureToFile([[panel filename]  cString],plane[0],w,h);
      ^
In file included from LynkeosFfmpegMovie.h:7:0,
                 from MyImageListItem.h:38,
                 from MyDocument.h:31,
                 from MyDocument.m:33:
ffmpeg_access.h:25:5: note: expected 'char *' but argument is of type '__u_char *'
 int saveTIFFPictureToFile(char* fileName,char* buffer,unsigned int width, unsigned int height);
     ^
MyDocument.m: In function '-[MyDocument processDidCreate:]':
MyDocument.m:1103:10: warning: passing argument 1 of 'setStack:size:' from incompatible pointer type [enabled by default]
          [list setStack:nil size:0];
          ^
MyDocument.m:1103:10: note: expected 'struct RGB *' but argument is of type 'id'
[...]
MyImageList.m: In function '-[MyImageList encodeWithCoder:]':
MyImageList.m:41:19: warning: comparison of distinct pointer types lacks a cast [enabled by default]
    if ( _rawStack != nil )
                   ^
MyImageList.m: In function '-[MyImageList init]':
MyImageList.m:139:17: warning: assignment from incompatible pointer type [enabled by default]
       _rawStack = nil;
                 ^
[...]
MyImageView.m: In function '-[MyImageView setImage:offset:]':
MyImageView.m:187:3: warning: initialization from distinct Objective-C type [enabled by default]
   NSBitmapImageRep*  bitMap = [image bestRepresentationForDevice:nil]; // get a rep from your image, or grab from a view
   ^
MyImageView.m:219:5: warning: implicit declaration of function 'asprintf' [-Wimplicit-function-declaration]
     nbBytes = asprintf(&header, "P6\n%d %d\n255\n", w, h);
     ^
[...]
MyListProcessing.m: In function '-[MyImageAligner init]':
MyListProcessing.m:407:26: warning: assignment from incompatible pointer type [enabled by default]
       _referenceSpectrum = nil;
                          ^
MyListProcessing.m: In function '-[MyImageAligner alignWithList:reference:refBuffer:lock:darkFrame:flatField:rectangle:cutOff:precisionThreshold:]':
MyListProcessing.m:463:23: warning: passing argument 6 of 'getImageSample' from incompatible pointer type [enabled by default]
                       (REAL*)_referenceSpectrum->spectrum, nil, 1 );
                       ^
MyListProcessing.m:35:13: note: expected 'struct RGB *' but argument is of type 'id'
 static void getImageSample( MyImageListItem* item, RGB *dark, RGB *flat,
             ^
MyListProcessing.m: In function '-[MyImageAligner processItem:]':
MyListProcessing.m:499:23: warning: passing argument 6 of 'getImageSample' from incompatible pointer type [enabled by default]
                       (REAL*)_bufferSpectrum.spectrum, nil, 1 );
                       ^
MyListProcessing.m:35:13: note: expected 'struct RGB *' but argument is of type 'id'
 static void getImageSample( MyImageListItem* item, RGB *dark, RGB *flat,
             ^
MyListProcessing.m: In function '-[MyImageStack processItem:]':
MyListProcessing.m:695:23: warning: passing argument 5 of 'getImageSample' from incompatible pointer type [enabled by default]
                       _factor );
                       ^
MyListProcessing.m:35:13: note: expected 'REAL *' but argument is of type 'id'
 static void getImageSample( MyImageListItem* item, RGB *dark, RGB *flat,
             ^
[...]
MyPostProcessing.m: In function '-[MyPostProcessing makeImageWithMin:Max:]':
MyPostProcessing.m:324:10: warning: passing argument 1 of 'initWithBitmapDataPlanes:pixelsWide:pixelsHigh:bitsPerSample:samplesPerPixel:hasAlpha:isPlanar:colorSpaceName:bytesPerRow:bitsPerPixel:' from incompatible pointer type [enabled by default]
          bitsPerPixel:0]
          ^
MyPostProcessing.m:324:10: note: expected 'unsigned char **' but argument is of type 'id'
[...]
LynkeosFfmpegMovie.m: In function '-[LynkeosFfmpegMovie initWithURL:byReference:]':
LynkeosFfmpegMovie.m:25:6: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]
   cs = [[url path] cString];
      ^
LynkeosFfmpegMovie.m: In function '-[LynkeosFfmpegMovie loadImageDataIn:]':
LynkeosFfmpegMovie.m:96:3: warning: implicit declaration of function 'asprintf' [-Wimplicit-function-declaration]
   nbBytes = asprintf(&header, "P6\n%d %d\n255\n", width, height);
   ^

The full build log is available upon request.
The severity of this bug may be raised to "important", "serious" or
"grave" after the transition depending on the impact.

[*]
http://mentors.debian.net/debian/pool/main/g/gnustep-make/gnustep-make_2.6.6-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-base/gnustep-base_1.24.6-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-gui/gnustep-gui_0.24.0-1.dsc
http://mentors.debian.net/debian/pool/main/g/gnustep-back/gnustep-back_0.24.0-1.dsc