Bug#816148: gnutls28: parallel build fails

[Samuel Thibault]

Source: gnutls28
Version: 10
Severity: normal
Tags: patch

Hello,

On a 32-processor machine, the parallel build of gnutls28 failed:

In file included from systemkey.c:47:0:
systemkey-args.h:1:1: error: unterminated comment
 /*   -*- buffer-read-only: t -*- vi: set ro:
 ^
systemkey.c: In function 'cmd_parser':
systemkey.c:80:10: warning: implicit declaration of function 'optionProcess' [-Wimplicit-function-declaration]
  optct = optionProcess(&systemkey_toolOptions, argc, argv);
          ^
systemkey.c:80:2: warning: nested extern declaration of 'optionProcess' [-Wnested-externs]
  optct = optionProcess(&systemkey_toolOptions, argc, argv);
  ^
systemkey.c:80:25: error: 'systemkey_toolOptions' undeclared (first use in this function)
  optct = optionProcess(&systemkey_toolOptions, argc, argv);
                         ^
systemkey.c:80:25: note: each undeclared identifier is reported only once for each function it appears in
systemkey.c:86:6: warning: implicit declaration of function 'HAVE_OPT' [-Wimplicit-function-declaration]
  if (HAVE_OPT(DEBUG)) {
      ^

It looks like the Makefile didn't wait for systemkey-args.h to be
finished writing before compiling systemkey.c.

It thus seems unsafe to allow parallel build until such kind of missing
dependency is fixed.

Samuel

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
 > et sinon, quand on s'interesse a un media que l'on ne maitrise pas,
 > on essaye de le comprendre d'abord.
 (Suivi par l'intégralité du message initial de 45 lignes.)
 -+-BM in : GNU - La maîtrise est un long apprentissage petit scarabé -+-
-------------- next part --------------
--- debian/rules.original	2016-02-28 02:41:19.400776553 +0100
+++ debian/rules	2016-02-28 02:41:54.225184749 +0100
@@ -58,7 +58,7 @@
 	rm -fv `grep -El 'has been AutoGen-ed |has been AutoGen-ed *$$' doc/manpages/*.?`
 
 override_dh_auto_build:
-	dh_auto_build --verbose --parallel
+	dh_auto_build --verbose
 ifeq ($(filter --disable-doc,$(AMCONFBUILDINDEP)),)
 	$(MAKE) html
 else
@@ -106,7 +106,7 @@
 	dh_strip --ddeb-migration='libgnutls30-dbg (<< 3.4.7-2~)'
 
 override_dh_auto_test:
-	dh_auto_test -O--parallel || touch dh_auto_test.fail
+	dh_auto_test || touch dh_auto_test.fail
 	@if test -e dh_auto_test.fail ; then \
 		find -name test-suite.log | \
 		while read i ; do \
@@ -117,4 +117,4 @@
 	dh_clean -X.bak
 
 %:
-	dh $@ --parallel --with autoreconf
+	dh $@ --with autoreconf