[pkg-go] Sponsor needed for NEW package pt-websocket

Michael Stapelberg stapelberg at debian.org
Fri May 30 08:21:56 UTC 2014

Hi Ximin,

Sorry for the late reply, I’m pretty busy these days.

Ximin Luo <infinity0 at pwned.gg> writes:
> - override dh_auto_build and dh_auto_test to exclude
> pt-websocket-client. This is because it depends on code not yet in
> Debian (go.net/websocket). I agree it's nice to build it, but I don't
> think we should block the release of this package to do so.
Actually, I’d prefer to have websocket be in debian and this package to
just use it. Otherwise we’ll end up with one more embedded source copy,
and we already have way too many packages which do that.

> override_dh_auto_build:
> 	cd $(DH_BUILDDIR) && GOPATH=$$PWD go install -v $(DH_GOPKG_SUBDIRS:%=$(DH_GOPKG)/%)
> 	make doc/pt-websocket-server.1
This still sets GOPATH and hence suffers from the same problem I tried
to point out in my last email on this thread.

Please avoid calling go(1) directly at all in the entire Makefile and
instead rely on dh_golang.

> - an option to not install the source code
> (DH_GOLANG_INSTALL_EXCLUDE_SOURCE?), instead of me having to override
> dh_auto_install with a rm. I imagine this would be a fairly common
> use-case for binaries that don't need to distribute a -dev package.
True. I think this is a good addition. Can you please file a wishlist
bug against dh_golang so that we don’t forget?

Best regards,

More information about the Pkg-go-maintainers mailing list