[pkg-go] Sponsor needed for NEW package pt-websocket

[Ximin Luo]

On 30/05/14 09:21, Michael Stapelberg wrote:
> Hi Ximin,
> 
> Sorry for the late reply, I’m pretty busy these days.
> 
> Ximin Luo <infinity0 at pwned.gg> writes:
>> - override dh_auto_build and dh_auto_test to exclude
>> pt-websocket-client. This is because it depends on code not yet in
>> Debian (go.net/websocket). I agree it's nice to build it, but I don't
>> think we should block the release of this package to do so.
> Actually, I’d prefer to have websocket be in debian and this package to
> just use it. Otherwise we’ll end up with one more embedded source copy,
> and we already have way too many packages which do that.
> 

We don't embed any source copies, this is just *example code*. The user needs to pull in go.net/websocket himself if he wants to build it.

I can do the "build to check it compiles" thing later when go.net/websocket enters Debian, but if we wait for that, this would be blocking release on a *very non-essential* item.

> 
>> override_dh_auto_build:
>> 	cd $(DH_BUILDDIR) && GOPATH=$$PWD go install -v $(DH_GOPKG_SUBDIRS:%=$(DH_GOPKG)/%)
>> 	make doc/pt-websocket-server.1
> This still sets GOPATH and hence suffers from the same problem I tried
> to point out in my last email on this thread.
> 
> Please avoid calling go(1) directly at all in the entire Makefile and
> instead rely on dh_golang.
> 

Setting GOPATH like this is exactly what dh_golang does. I only override it this way because dh_golang is not flexible enough, like I explained in my last email. *I cannot use dh_golang.*

X

>> - an option to not install the source code
>> (DH_GOLANG_INSTALL_EXCLUDE_SOURCE?), instead of me having to override
>> dh_auto_install with a rm. I imagine this would be a fairly common
>> use-case for binaries that don't need to distribute a -dev package.
> True. I think this is a good addition. Can you please file a wishlist
> bug against dh_golang so that we don’t forget?
> 

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 880 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20140530/0e448621/attachment.sig>