[pkg-go] Sponsor needed for NEW package pt-websocket

Michael Stapelberg stapelberg at debian.org
Sun Jun 1 11:44:38 UTC 2014

Hi Ximin,

Ximin Luo <infinity0 at pwned.gg> writes:
>> Ximin Luo <infinity0 at pwned.gg> writes:
>>> - override dh_auto_build and dh_auto_test to exclude
>>> pt-websocket-client. This is because it depends on code not yet in
>>> Debian (go.net/websocket). I agree it's nice to build it, but I don't
>>> think we should block the release of this package to do so.
>> Actually, I’d prefer to have websocket be in debian and this package to
>> just use it. Otherwise we’ll end up with one more embedded source copy,
>> and we already have way too many packages which do that.
> We don't embed any source copies, this is just *example code*. The
> user needs to pull in go.net/websocket himself if he wants to build
> it.
Thanks for clarifying.

>>> override_dh_auto_build:
>>> 	cd $(DH_BUILDDIR) && GOPATH=$$PWD go install -v $(DH_GOPKG_SUBDIRS:%=$(DH_GOPKG)/%)
>>> 	make doc/pt-websocket-server.1
>> This still sets GOPATH and hence suffers from the same problem I tried
>> to point out in my last email on this thread.
>> Please avoid calling go(1) directly at all in the entire Makefile and
>> instead rely on dh_golang.
> Setting GOPATH like this is exactly what dh_golang does. I only
> override it this way because dh_golang is not flexible enough, like I
> explained in my last email. *I cannot use dh_golang.*
Sorry, I didn’t pick up on the fact that dh_auto_configure is still run
by dh_golang and hence you’ll get the properly set up build
directory. This is okay for now, but in the long run it’d be good to
switch to dh-golang after https://bugs.debian.org/734787 is fixed :).

I went ahead and uploaded the version currently in the
repository. Thanks for your work!

Best regards,

More information about the Pkg-go-maintainers mailing list