[pkg-go] Rewrite of etcd init script

Dmitry Smirnov onlyjob at debian.org
Mon Sep 28 03:55:10 UTC 2015


On Sunday 27 September 2015 23:44:01 Jelmer Vernooij wrote:
> You recently rewrote the init script for etcd.
> 630cf70e60a996c0e38327e42ea1d106441a04ac removes all the code that
> updates DAEMON_ARGS.

That is correct. New style is much simpler and contains more reusable code.
A special effort was made to make SysV script and Systemd service files to 
behave alike and to properly load settings from "/etc/default/etcd".

Why are you so concerned about it?


> Is it supposed to pick up the settings from
> /etc/default/etcd in some other way?
> AFAICT they're not explicitly expoted either.

Other way?? Command

    . /etc/default/etcd

automatically exports variables for us. Then daemon uses settings from known 
variables as per 

    https://github.com/coreos/etcd/blob/master/Documentation/configuration.md

Do you have any problems with new init scripts?

They have passed my run-time testing successfully.
I reckon you did not try new SysV init script yet? ;)

-- 
Regards,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

It is a mistake to try to look too far ahead. The chain of destiny can only
be grasped one link at a time.
        -- Winston Churchill

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20150928/f0b5a4a0/attachment.sig>


More information about the Pkg-go-maintainers mailing list