[pkg-go] Rewrite of etcd init script

[Jelmer Vernooij]

On Mon, Sep 28, 2015 at 01:55:10PM +1000, Dmitry Smirnov wrote:
> On Sunday 27 September 2015 23:44:01 Jelmer Vernooij wrote:
> > You recently rewrote the init script for etcd.
> > 630cf70e60a996c0e38327e42ea1d106441a04ac removes all the code that
> > updates DAEMON_ARGS.
> 
> That is correct. New style is much simpler and contains more reusable code.
> A special effort was made to make SysV script and Systemd service files to 
> behave alike and to properly load settings from "/etc/default/etcd".
> 
> Why are you so concerned about it?
It doesn't work.

> > Is it supposed to pick up the settings from
> > /etc/default/etcd in some other way?
> > AFAICT they're not explicitly expoted either.
> 
> Other way?? Command
> 
>     . /etc/default/etcd
> 
> automatically exports variables for us. 
That just makes the variables available to the init script, it doesn't
export them - so they're not available to the etcd binary.

root at gwalcmai:~# grep ^ETCD_ /etc/default/etcd
ETCD_CERT_FILE=/etc/etcd/etcd.pem
ETCD_KEY_FILE=/etc/etcd/etcd.key
ETCD_PEER_CERT_FILE=/etc/etcd/etcd.pem
ETCD_PEER_KEY_FILE=/etc/etcd/etcd.key
ETCD_CLIENT_CERT_AUTH=true
ETCD_PEER_CLIENT_CERT_AUTH=true
root at gwalcmai:~# etcd 2>&1 | grep recognized
^C
root at gwalcmai:~# export ETCD_CLIENT_CERT_AUTH
root at gwalcmai:~# etcd 2>&1 | grep recognized
2015-09-28 23:14:05.842945 I | flags: recognized and used environment
variable ETCD_CLIENT_CERT_AUTH=true
^C

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer at debian.org>
Debian Developer                           https://jelmer.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20150928/2405ecc8/attachment.sig>