[pkg-go] Rewrite of etcd init script

[Jelmer Vernooij]

On Tue, Sep 29, 2015 at 12:04:22PM +1000, Dmitry Smirnov wrote:
> On Monday 28 September 2015 23:39:41 Jelmer Vernooij wrote:
> > > for me as I was able to successfully bootstrap etcd member in clean
> > > SysV/sid environment using new style config.
> > etcd doesn't start with the expected settings.
> > 
> > Can you reproduce setting up an etcd member in a sid environment?
> 
> I already wrote this like 3 lines above: "I was able to successfully 
> bootstrap etcd member in clean SysV/sid environment using new style config."
> 
> I just repeated this experiment again and everything works perfectly.
> 
> Which settings do not work for you, specifically?
Argh, it was really simple. The variable names have silently been
renamed to include a ETCD_ prefix, breaking existing locations like
mine.

> > > > That just makes the variables available to the init script, it doesn't
> > > > export them - so they're not available to the etcd binary.
> > > 
> > > This is not what I observe here. Perhaps we could add explicit exports
> > > but I wonder how (and why) it does not work for you.
> > 
> > Even so, how are you expecting this to work? How are these environment
> > variables supposed to be picked up by etcd if they're not exported?
> 
> Environment variables are exported. You are describing default behaviour of 
> "source" or "." (dot) operator which I override with "set -a" which "Export 
> all variables assigned to", see "Argument List Processing" section of man 
> page [1].

Ah, cheers. I missed that on first reading the script.

Jelmer

-- 
Jelmer Vernooij <jelmer at debian.org>
Debian Developer                           https://jelmer.uk/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20150930/e6e4e84a/attachment.sig>