[pkg-go] Rewrite of etcd init script

Dmitry Smirnov onlyjob at debian.org
Wed Sep 30 04:21:22 UTC 2015


On Wednesday 30 September 2015 03:02:21 Jelmer Vernooij wrote:
> Argh, it was really simple. The variable names have silently been
> renamed to include a ETCD_ prefix, breaking existing locations like
> mine.

Yeah, that's the cost of compatibility with upstream so conf fragment printed 
by "etcdctl member add" could be used as-is without translation to old 
variable convention. We had to move to new upstream variable names, also to 
avoid collisions with generic "$NAME" etc. Preserving compatibility with 
unfinished package from "experimental" would require quite an effort for 
little gain so naturally I did not do it...
I thought that DPKG prompt to merge conffile should raise enough attention...

Also "debug" mode helps as Etcd logs very clearly which variables are used.

Speaking about logs, I'm a bit concerned that current SysV init script 
discards log entirely... Do you think we should log to "/var/log/etcd.log" 
and drop "debug" mode? I could not figure out how to log to syslog on SysV...


> Ah, cheers. I missed that on first reading the script.

No worries. :) I'm glad that everything is OK. :)

-- 
Best wishes,
 Dmitry Smirnov.

---

I am easily satisfied with the very best.
        -- Winston Churchill
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20150930/3f727085/attachment.sig>


More information about the Pkg-go-maintainers mailing list