[pkg-go] Circular dependency in a test file

[Martín Ferrari]

Hi Arnaud,

On 13/02/18 12:37, Arnaud wrote:

> The fact that it breaks dh-make-dolang is not the blocker here, as I can
> workaround and create the packaging files manually. However, what should
> I do with this `marshal_test.go` file ? Should I exclude it from the
> package ? Or should I patch it ?

You could either add an exclusion during build/test, or you can patch it
so it is ignored with '// +build ignore'. If you go with the exclusion,
you should probably add the dependency in the package dependencies (not
in the build-deps), but unless it is a very important test, maybe it is
better to just disable it.

> And more generally: I've noticed that a lot of go packages have test
> files named `*_test.go` Is it good policy to remove them from the
> package when they get in the way like this ? Or are they needed in some
> way that I don't expect ?

We usually keep them in the package, so tests can be run from the
installed package, including in ci.debian.net.

-- 
Martín Ferrari (Tincho)