[pkg-go] Circular dependency in a test file

Arnaud arnaud.rebillout at collabora.com
Tue Feb 13 14:46:49 UTC 2018

Hi Tincho,

thanks a lot for all the details !

On 02/13/2018 07:10 PM, Martín Ferrari wrote:
> Hi Arnaud,
> On 13/02/18 12:37, Arnaud wrote:
>> The fact that it breaks dh-make-dolang is not the blocker here, as I can
>> workaround and create the packaging files manually. However, what should
>> I do with this `marshal_test.go` file ? Should I exclude it from the
>> package ? Or should I patch it ?
> You could either add an exclusion during build/test, or you can patch it
> so it is ignored with '// +build ignore'. If you go with the exclusion,
> you should probably add the dependency in the package dependencies (not
> in the build-deps), but unless it is a very important test, maybe it is
> better to just disable it.

I think in this particular case it's better to disable the test and get
rid of the dependency to containerd. Here we're talking about a
lightweight library, it wouldn't make sense to make it depend on
containerd which is a super heavy package.



More information about the Pkg-go-maintainers mailing list