[pkg-go] Bug#890501: Bug#890501: prometheus startup fails due to racey PID file implementation in prometheus

[Martín Ferrari]

Hi Tim,

On 15/02/18 12:09, Tim Small wrote:

> Due to https://github.com/prometheus/prometheus/issues/2689 Prometheus
> may fail to start (most commonly after a reboot), since the lock file
> checking implementation it uses is naive (just "is there a pid running
> with the same pid number that I wrote to the pid file").
> 
> The recommended (by upstream) workaround is to disable the lock file
> checking by using the --storage.tsdb.no-lockfile commandline argument
> when starting prometheus from the systemd unit file etc.

Thanks for your bug report. I had no idea there was now a tsdb lockfile,
and I agree that it makes sense to disable it, since we have that
functionality implemented in the init/service files.


-- 
Martín Ferrari (Tincho)