[pkg-go] Call for review - containerd and dependencies

[Arnaud Rebillout]

On 03/20/2018 02:36 PM, Michael Stapelberg wrote:
>
>
> On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout
> <arnaud.rebillout at collabora.com
> <mailto:arnaud.rebillout at collabora.com>> wrote:
>
>     Hello all, let me follow up on this !
>
>     According to discussions on this mailing list, I made the
>     following changes on the packages:
>
>     - the license issues have been clarified with containerd projects,
>     except for containerd-typeurl which doesn't receive much attention
>     from upstream. As a consequence I let the copyright to
>     'containerd', except if there's a better thing to do (like,
>     nothing in the copyright field ?).
>     - I re-packaged docker-go-metrics to a lower version, so that
>     there is no need to bump prometheus-client-golang.
>     - I think I addressed most (if all) of the comments from Michael,
>     ie. DEP-3 patches, more lintian warnings fixed, and others all
>     along the discussion.
>
>     So let me sum up here the list of packages we're talking about,
>     and that received changes.
>
>     FORGET ABOUT (because it's not needed anymore)
>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang>
>
>     CLONE AGAIN (don't pull because I re-wrote history)
>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics>
>
>
> Uploaded.
>  
>
>
>
>     PULL - there are a few changes
>
>     <https://salsa.debian.org/elboulangero-guest/containerd>
>     <https://salsa.debian.org/elboulangero-guest/containerd>
>
>
> I’ll hold off with this one until the build-deps are satisfied.
>
> By the way, do you want to include the most recent commits in the
> debian/changelog entry?

Yep sure, I just updated the changelog and pushed it all.

>  
>
>     <https://salsa.debian.org/elboulangero-guest/continuity>
>     <https://salsa.debian.org/elboulangero-guest/continuity>
>
>
> Looks good. Can you move this repository to its intended location
> https://salsa.debian.org/go-team/packages/continuity please?

Repo moved.

>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs>
>
>
>  The description for golang-github-containerd-btrfs-dev should be
> trimmed: upstream’s recommendation to vendor the package doesn’t make
> sense in Debian, and neither does the contribution guidelines.
>
> Looks good otherwise. Can you move it
> to https://salsa.debian.org/go-team/packages/golang-github-containerd-btrfs
> please?

Description updated, repo moved.

>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl>
>
>
>  Looks good. Can you move this
> to https://salsa.debian.org/go-team/packages/golang-github-containerd-typeurl
> please?

Repo moved.

>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events>
>
>
>  Uploaded.
>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec>
>     <https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec>
>
>
>  This one is missing a debian/changelog entry for your changes.

Indeed, I pushed some last changes.
>
>     <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc>
>     <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc>
>
>
> Looks good. Can you move this
> to https://salsa.debian.org/elboulangero-guest/golang-gogottrpc
> <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc> please?

Repo moved.

>  
>
>
>
>     PULL - these packages have been rejected due to copyright issues
>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-console>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-console>
>
>
> Uploaded.
>  
>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo>
>
>
> Uploaded.
>  
>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-go-runc>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-go-runc>
>
>
> Uploaded.

Ok, according to the mails from FTP Masters 'fifo' and 'go-runc' have
made it to the NEW queue.

However 'console' seem to have an issue, it is REJECTED because
'Source-only uploads' are not accepted. Is there anything I can do here ?

>  
>
>
>     PULL - this package is already in Debian Sid, should I issue a new
>     Debian release due to copyright change ?
>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups>
>     <https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups>
>
>
> Yes please. It’s always good to not leave pending changes lying around
> (for people touching the package in the future).

Ok done, I let you add the tag on the master branch. BTW there was no
tag for 'version 0.0~git20180223.d578e4e-1'.

>  
>
>
>     Ok I think I didn't forget anything :)
>
>     Feel free to tell me if there's anything that is still not ok with
>     these packages, if there's anything I should do. Like, should I
>     always finish with a commit that updates the changelog
>
>
> Yes please.

Noted :)

>  
>
>     (which I didn't do), or not ? Is it OK to have a debian release
>     ending with '-2' or more if the package was *never* uploaded
>     before (I know that reprepro doesn't like that, but I guess the
>     Debian infra doesn't use reprepro).
>
>
> Debian doesn’t use reprepro, but it would be easier to use -1 until
> the package was uploaded. Otherwise, the uploader needs to remember to
> use the -v option to include all changelog entries in the .changes file.

Ok I'll take care about that, thanks for the explanations.

Thanks,

  Arnaud
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180320/b79c3388/attachment-0001.html>