[pkg-go] Call for review - containerd and dependencies

Wed Mar 21 07:55:17 UTC 2018

On Tue, Mar 20, 2018 at 11:59 AM, Arnaud Rebillout <
arnaud.rebillout at collabora.com> wrote:

>
>
> On 03/20/2018 02:36 PM, Michael Stapelberg wrote:
>
>
>
> On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout <
> arnaud.rebillout at collabora.com> wrote:
>
>> Hello all, let me follow up on this !
>>
>> According to discussions on this mailing list, I made the following
>> changes on the packages:
>> - the license issues have been clarified with containerd projects, except
>> for containerd-typeurl which doesn't receive much attention from upstream.
>> As a consequence I let the copyright to 'containerd', except if there's a
>> better thing to do (like, nothing in the copyright field ?).
>> - I re-packaged docker-go-metrics to a lower version, so that there is no
>> need to bump prometheus-client-golang.
>> - I think I addressed most (if all) of the comments from Michael, ie.
>> DEP-3 patches, more lintian warnings fixed, and others all along the
>> discussion.
>>
>> So let me sum up here the list of packages we're talking about, and that
>> received changes.
>>
>> FORGET ABOUT (because it's not needed anymore)
>> <https://salsa.debian.org/elboulangero-guest/golang-github-d
>> mcgowan-go-tar>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-p
>> rometheus-client-golang>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang>
>>
>> CLONE AGAIN (don't pull because I re-wrote history)
>>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-d
>> ocker-go-metrics>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics>
>>
>
> Uploaded.
>
>
>>
>>
>> PULL - there are a few changes
>>
>> <https://salsa.debian.org/elboulangero-guest/containerd>
>> <https://salsa.debian.org/elboulangero-guest/containerd>
>>
>
> I’ll hold off with this one until the build-deps are satisfied.
>
> By the way, do you want to include the most recent commits in the
> debian/changelog entry?
>
>
> Yep sure, I just updated the changelog and pushed it all.
>

I can’t seem to build this because
https://tracker.debian.org/pkg/golang-github-opencontainers-image-spec is
broken, and I’m not entirely sure why/how to fix it. Any hints welcome.

>
>
>
>
>> <https://salsa.debian.org/elboulangero-guest/continuity>
>> <https://salsa.debian.org/elboulangero-guest/continuity>
>>
>
> Looks good. Can you move this repository to its intended location
> https://salsa.debian.org/go-team/packages/continuity please?
>
>
> Repo moved.
>

Uploaded.

>
>
>
> <https://salsa.debian.org/elboulangero-guest/golang-github-c
>> ontainerd-btrfs>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs>
>>
>
>  The description for golang-github-containerd-btrfs-dev should be
> trimmed: upstream’s recommendation to vendor the package doesn’t make sense
> in Debian, and neither does the contribution guidelines.
>
> Looks good otherwise. Can you move it to https://salsa.debian.org/go
> -team/packages/golang-github-containerd-btrfs please?
>
>
> Description updated, repo moved.
>

Uploaded.

>
>
>
> <https://salsa.debian.org/elboulangero-guest/golang-github-c
>> ontainerd-typeurl>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl>
>>
>
>  Looks good. Can you move this to https://salsa.debian.org/go
> -team/packages/golang-github-containerd-typeurl please?
>
>
> Repo moved.
>

Uploaded.

>
>
>
> <https://salsa.debian.org/elboulangero-guest/golang-github-d
>> ocker-go-events>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events>
>>
>
>  Uploaded.
>
> <https://salsa.debian.org/elboulangero-guest/golang-github-o
>> pencontainers-image-spec>
>> <https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec>
>>
>
>  This one is missing a debian/changelog entry for your changes.
>
>
> Indeed, I pushed some last changes.
>

Looks good, can you move it please?

>
>
> <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc>
>> <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc>
>>
>
> Looks good. Can you move this to https://salsa.debian.org/el
> boulangero-guest/golang-gogottrpc please?
>
>
> Repo moved.
>

Uploaded.

>
>
>
>
>>
>>
>> PULL - these packages have been rejected due to copyright issues
>>
>> <https://salsa.debian.org/go-team/packages/golang-github-con
>> tainerd-console>
>> <https://salsa.debian.org/go-team/packages/golang-github-containerd-console>
>>
>
> Uploaded.
>
>
>> <https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo>
>> <https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo>
>>
>
> Uploaded.
>
>
>> <https://salsa.debian.org/go-team/packages/golang-github-con
>> tainerd-go-runc>
>> <https://salsa.debian.org/go-team/packages/golang-github-containerd-go-runc>
>>
>
> Uploaded.
>
>
> Ok, according to the mails from FTP Masters 'fifo' and 'go-runc' have made
> it to the NEW queue.
>
> However 'console' seem to have an issue, it is REJECTED because
> 'Source-only uploads' are not accepted. Is there anything I can do here ?
>

I re-uploaded the amd64 .changes now.

>
>
>
>
>>
>> PULL - this package is already in Debian Sid, should I issue a new Debian
>> release due to copyright change ?
>>
>> <https://salsa.debian.org/go-team/packages/golang-github-con
>> tainerd-cgroups>
>> <https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups>
>>
>
> Yes please. It’s always good to not leave pending changes lying around
> (for people touching the package in the future).
>
>
> Ok done, I let you add the tag on the master branch. BTW there was no tag
> for 'version 0.0~git20180223.d578e4e-1'.
>

Uploaded.

>
>
>
>
>>
>> Ok I think I didn't forget anything :)
>>
>> Feel free to tell me if there's anything that is still not ok with these
>> packages, if there's anything I should do. Like, should I always finish
>> with a commit that updates the changelog
>>
>
> Yes please.
>
>
> Noted :)
>
>
>
>> (which I didn't do), or not ? Is it OK to have a debian release ending
>> with '-2' or more if the package was *never* uploaded before (I know that
>> reprepro doesn't like that, but I guess the Debian infra doesn't use
>> reprepro).
>>
>
> Debian doesn’t use reprepro, but it would be easier to use -1 until the
> package was uploaded. Otherwise, the uploader needs to remember to use the
> -v option to include all changelog entries in the .changes file.
>
>
> Ok I'll take care about that, thanks for the explanations.
>
> Thanks,
>
>   Arnaud
>

-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180321/122fb503/attachment-0001.html>