[pkg-go] Bug#901310: gitaly hard codes gitlab username and it does not use the same options to adduser as gitlab package

Dmitry Smirnov onlyjob at debian.org
Mon Jun 11 10:55:35 BST 2018


On Monday, 11 June 2018 6:52:59 PM AEST Pirate Praveen wrote:
> It should check the username from debconf db already set by gitlab and
> also ask debconf question if not set already.

It should not fail to install on the box without gitlab. It should install 
successfully even if gitlab was never installed.

IMHO this is not much value in debconf prompt for user name... It may be nice 
but perhaps would be excessive in most cases.

I mean, "gitlab" user name is much like "www-data". Maybe it would be best 
not to alter it through debconf to avoid significant maintenance overhead for 
little value.

How are you going to alter .service file? Are you sure it is worth the 
trouble?


> postrm should not remove the user if gitlab package is still present.

I would only implement this so purge wouldn't remove "gitlab" user when 
gitlab is installed.

-- 
Cheers,
 Dmitry Smirnov.

---

Truth — Something somehow discreditable to someone.
        -- H. L. Mencken, 1949

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-go-maintainers/attachments/20180611/355956ef/attachment.sig>


More information about the Pkg-go-maintainers mailing list