[pkg-go] Bug#901310: gitaly hard codes gitlab username and it does not use the same options to adduser as gitlab package

[Pirate Praveen]

On June 11, 2018 3:25:35 PM GMT+05:30, Dmitry Smirnov <onlyjob at debian.org> wrote:
>On Monday, 11 June 2018 6:52:59 PM AEST Pirate Praveen wrote:
>> It should check the username from debconf db already set by gitlab
>and
>> also ask debconf question if not set already.
>
>It should not fail to install on the box without gitlab. It should
>install 
>successfully even if gitlab was never installed.

I think the solution is to have a gitlab-common package that will handle the user creation with both gitlab and gitaly depending on it.

>IMHO this is not much value in debconf prompt for user name... It may
>be nice 
>but perhaps would be excessive in most cases.
>
>I mean, "gitlab" user name is much like "www-data". Maybe it would be
>best 
>not to alter it through debconf to avoid significant maintenance
>overhead for 
>little value.

It is significant because it forms the ssh URL and visible to every user of the service.

git at domain.tld is preferred by many whereas default is gitlab at domain.tld

>How are you going to alter .service file? Are you sure it is worth the 
>trouble?

Just how we did it for gitlab.

>
>> postrm should not remove the user if gitlab package is still present.
>
>I would only implement this so purge wouldn't remove "gitlab" user when
>
>gitlab is installed.

gitlab-common as explained above can fix this.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.