[pkg-go] Bug#971898: src:syncthing: Please add possibly missing build dependencies

[Andrej Shadura]

Control: notfound -1 1.9.0~ds1-2

On Fri, 9 Oct 2020, at 14:19, Simon Frei wrote:
> Hi Andrej,
> 
> On 09/10/2020 12:12, Andrej Shadura wrote:
> > While syncing syncthing to Ubuntu, Dmitry (in Cc) found an issue with
> > missing build dependencies:
> There wasn't any CC in the mail I got, if relevant please forward this
> email to Dmitry.

I added him to X-Debbugs-Cc, I think it should have worked?

> > https://bugs.launchpad.net/ubuntu/+source/syncthing/+bug/1897447
> >
> > which resulted in a patch (see attachment). Please have a look and apply
> > those changes in Debian too, if necessary.
> Those are transitive dependencies of badger and get already installed
> before building, see e.g. this build log for amd64:
> https://buildd.debian.org/status/fetch.php?pkg=syncthing&arch=amd64&ver=1.9.0%7Eds1-2&stamp=1600901129&raw=0

Indeed, it was a bug in badger which was fixed in 2.0.3-2 (Ubuntu ships badger 2.0.3-1 apparently).
So instead of patching it in syncthing, it’s probably best to pull newer badger anyway.

-- 
Cheers,
  Andrej