[pkg-go] Bug#974159: gitaly: Error in postinst script

[Leopold Palomo-Avellaneda]

Package: gitaly
Version: 13.3.9+dfsg-1+fto10+1
Severity: normal

Installing gitaly I have found that if it's an upgrade, or install, and
it's installed, there's and error because when the script is executed,
in the line 50:

# Check if storage path exist and create if required
  export $(grep '^\s*path\s*=' /etc/gitaly/config.toml | sed 's/ //g' |
sed 's/"//g')
  if ! [ -d $path ] ; then runuser -u ${gitlab_user} -- sh -c 'mkdir
$path'; fi

The problem is the path in my case contains:
'/home/projects/gitlab/repositories'. Pay attention in the ' ', so the
if ![-d $path] check for a '/home/projects/gitlab/repositories' and of
course my path doesn't exists. It exists without ''. So, when you try to
create the path , I don't know why, the '' disappears and the error
occurs because the path exists.

Hope have been clear.


-- System Information:
Debian Release: 10.6
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.6.0-0.bpo.2-amd64 (SMP w/16 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
TAINT_UNSIGNED_MODULE
Locale: LANG=ca_ES.UTF-8, LC_CTYPE=ca_ES.UTF-8 (charmap=UTF-8),
LANGUAGE=ca:en_US (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled


-- 
--
Linux User 152692     GPG: 05F4A7A949A2D9AA
Catalonia
-------------------------------------
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?