[pkg-go] Bug#982664: golang-github-fsouza-go-dockerclient: Please build-depend on golang-golang-x-crypto-dev

[Logan Rosen]

Package: golang-github-fsouza-go-dockerclient
Version: 1.6.6-1
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch

Hi,

golang-golang-x-crypto-dev is required for the buildtime tests to
succeed, but it is not an explicit build dependency. While it gets
pulled in transitively in Debian, it does not in Ubuntu. Could you
please add it as a build dependency accordingly?

In Ubuntu, the attached patch was applied to achieve the following:

    - d/control: Add missing golang-golang-x-crypto-dev build-dependency,
      needed for build-time tests.

Thanks for considering the patch.

Logan
-------------- next part --------------
diff -Nru golang-github-fsouza-go-dockerclient-1.6.6/debian/control golang-github-fsouza-go-dockerclient-1.6.6/debian/control
--- golang-github-fsouza-go-dockerclient-1.6.6/debian/control	2020-11-30 16:57:13.000000000 -0500
+++ golang-github-fsouza-go-dockerclient-1.6.6/debian/control	2021-02-12 22:14:27.000000000 -0500
@@ -15,6 +15,7 @@
 #   golang-github-opencontainers-runc-dev,
     golang-github-sirupsen-logrus-dev,
     golang-github-stretchr-testify-dev,
+    golang-golang-x-crypto-dev,
     golang-golang-x-net-dev,
     golang-golang-x-sys-dev,
 Homepage: https://github.com/fsouza/go-dockerclient