[pkg-go] Bug#989180: golang-github-smartystreets-assertions-dev: ShouldContain doesn't support slices

meskio meskio at sindominio.net
Thu May 27 18:37:52 BST 2021


Package: golang-github-smartystreets-assertions-dev
Version: 1.10.1+ds-1
Severity: normal

Dear Maintainer,

The debian package of github.com/smartystreets/assertions does unvendor
github.com/jacobsa/oglematchers, but the vendored version in the
assertions library did include some improvements. The one I care about
is adding support for slices in ShouldContain:
https://github.com/smartystreets/assertions/commit/6acd0337655254c23e16aae1be5acaa36576faf4#diff-0542b9c1330ae7fd11c64fede96abc85d3c9d5274979545e8c253cbae0ed5940

I'm building a package wich tests fail because it uses this feature.
Maybe this commit could be added as a patch in the debian package 
golang-github-jacobsa-oglematchers-dev, it looks pretty safe to add and
should not break any existing code.

Another option will be to remove the vendoring. oglematchers doesn't
seem be maintained, last commit is from 2015. The vendored version in 
smartystreets repo seems to be more maintained. To me it looks like the
only package that do depend on is the smartystreets/assertions, maybe
all the golang-github-jacobsa-*-dev packages can be removed.

What do you think? Can I help on anthing there?

Thank you.

-- System Information:
Debian Release: 11.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.12-3.pvops.qubes.x86_64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages golang-github-smartystreets-assertions-dev depends on:
ii  golang-github-jacobsa-oglematchers-dev  0.0~git20150320-3
ii  golang-golang-x-net-dev                 1:0.0+git20210119.5f4716e+dfsg-4

golang-github-smartystreets-assertions-dev recommends no packages.

golang-github-smartystreets-assertions-dev suggests no packages.

-- no debconf information



More information about the Pkg-go-maintainers mailing list